Add a comment to shutdown() in ncclSocketClose
Ta zmiana jest zawarta w:
%! (template.HTML=
Kaiming Ouyang)złożyło 2023-04-13 09:13:44 -07:00
1 rodzic
367e9b61c3
złożenie
006b6bc7dc
Plik 1 zmieniony
+4
@@ -819,6 +819,10 @@ ncclResult_t ncclSocketTryRecv(struct ncclSocket* sock, void* ptr, int size, int
|
||||
ncclResult_t ncclSocketClose(struct ncclSocket* sock) {
|
||||
if (sock != NULL) {
|
||||
if (sock->fd >= 0) {
|
||||
/* shutdown() is needed to send FIN packet to proxy thread; shutdown() is not affected
|
||||
* by refcount of fd, but close() is. close() won't close a fd and send FIN packet if
|
||||
* the fd is duplicated (e.g. fork()). So shutdown() guarantees the correct and graceful
|
||||
* connection close here. */
|
||||
shutdown(sock->fd, SHUT_RDWR);
|
||||
close(sock->fd);
|
||||
}
|
||||
|
||||
Reference in new issue
Zablokuj użytkownika