[SWDEV-518071] Return HSA not loaded status (device counter collection) (#242)

* [SWDEV-518071] Return HSA not loaded status (device counter collection)

This is a state that a caller would want to know about to understand if
they got no counters because of a failure or if they were trying to
collect counters too early (as is the case in the sample, which can
attempt to collect counters before HSA is inited).

* Minor edit

* format

* [SWDEV-518081] Simplify Metric Loading (#243)

* [SWDEV-518071] Return HSA not loaded status (device counter collection)

This is a state that a caller would want to know about to understand if
they got no counters because of a failure or if they were trying to
collect counters too early (as is the case in the sample, which can
attempt to collect counters before HSA is inited).
* [SWDEV-518324] Add AST update support

Allows the ability for ASTs to be updated (instead of an unchangable
static value). Adds a shared pointer return type to protect against
static destructors/modifications from invalidating potentially in use
AST definitions. No functionality/use changes in this PR.
* [SWDEV-518593] Add updatable dimension cache + fix string issues (#252)

* [SWDEV-518593] Add updatable dimension cache + fix string issues

Updates dimension cache to use the same design pattern as AST/Metrics.

Fixes the string scoping issue seen in ASTs, which appears here as well.

* Add rocprofiler_create_counter

Creates derived counters based on input from the API. This PR does three
things:

1. Adds the API + test case
2. Validates that an AST can be constructed from the counter supplied.
3. Updates metrics, ast, and dimension caches to include the new metric.

Metric should be available for use immediately after the call completes.

Due to the regeneration of ASTs, this call should not be performed in
performance sensitive code.

* Suggestion fixes

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>

* Minor tweak

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

* Fixes for comments

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Kandula, Venkateshwar reddy <Venkateshwarreddy.Kandula@amd.com>
Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Kandula, Venkateshwar reddy <Venkateshwarreddy.Kandula@amd.com>
Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

source/include/rocprofiler-sdk/counters.h

@@ -164,4 +164,36 @@ rocprofiler_iterate_agent_supported_counters(rocprofiler_agent_id_t
 
 /** @} */
 
+/**
+ * @brief Creates a new counter based on a derived metric provided. The counter will only
+ *        be available for counter collection profiles created after the addition of this counter.
+ *        Due to the regeneration of internal ASTs and dimension cache, this call may be slow and
+ *        should generally be avoided in performance sensitive code blocks (i.e. dispatch
+ *        callbacks).
+ *
+ * @param [in] name The name of the new counter.
+ * @param [in] name_len The length of the counter name.
+ * @param [in] expr The counter expression, formatted identically to YAML counter definitions.
+ * @param [in] expr_len The length of the expression.
+ * @param [in] agent The rocprofiler_agent_id_t specifying the agent for which to create the
+ * counter.
+ * @param [in] description The description of the new counter (optional).
+ * @param [in] description_len The length of the description.
+ * @param [out] counter_id The rocprofiler_counter_id_t of the created counter.
+ * @return ::rocprofiler_status_t
+ * @retval ROCPROFILER_STATUS_SUCCESS if the counter was successfully created.
+ * @retval ROCPROFILER_STATUS_ERROR_AST_GENERATION_FAILED if the counter could not be created.
+ * @retval ROCPROFILER_STATUS_ERROR_INVALID_ARGUMENT if a counter argument is incorrect
+ * @retval ROCPROFILER_STATUS_ERROR_AGENT_NOT_FOUND if the agent is not found
+ */
+rocprofiler_status_t
+rocprofiler_create_counter(const char*               name,
+                           size_t                    name_len,
+                           const char*               expr,
+                           size_t                    expr_len,
+                           const char*               description,
+                           size_t                    description_len,
+                           rocprofiler_agent_id_t    agent,
+                           rocprofiler_counter_id_t* counter_id) ROCPROFILER_NONNULL(1, 3, 8);
+
 ROCPROFILER_EXTERN_C_FINI