From 0097218f2b31b55e1ffde148ef4a8ba31691314e Mon Sep 17 00:00:00 2001 From: David Yat Sin Date: Fri, 14 Feb 2025 14:26:04 +0000 Subject: [PATCH] rocr: Only expose ext-fine-grain pool on xgmi-hive systems We cannot guarrantee system-scope coherency on systems with only PCIe connections, so do not expose extended fine-grain memory pool on these systems. [ROCm/ROCR-Runtime commit: 6dac90c89a4aa39c3fc8901a57a49150404a4e6d] --- .../runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/projects/rocr-runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp b/projects/rocr-runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp index 7499379368..0961cfd8f5 100644 --- a/projects/rocr-runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp +++ b/projects/rocr-runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp @@ -483,17 +483,16 @@ void GpuAgent::InitRegionList() { regions_.push_back(region); if (region->IsLocalMemory()) { - // Extended Fine-Grain memory - if (!(isa_->GetMajorVersion() == 12 && isa_->GetMinorVersion() == 0)) - regions_.push_back( - new MemoryRegion(false, false, false, true, true, this, mem_props[mem_idx])); - // Expose VRAM as uncached/fine grain over PCIe (if enabled) or XGMI. bool user_visible = (properties_.HiveID != 0) || core::Runtime::runtime_singleton_->flag().fine_grain_pcie(); regions_.push_back(new MemoryRegion(true, false, false, false, user_visible, this, mem_props[mem_idx])); + + // Extended Fine-Grain memory + regions_.push_back(new MemoryRegion(false, false, false, true, user_visible, this, + mem_props[mem_idx])); } break; }