From 02a862bde110cafdeb540abaf9665cfdebb9b828 Mon Sep 17 00:00:00 2001 From: Ori Messinger Date: Thu, 2 May 2024 13:59:14 -0400 Subject: [PATCH] ROCm SMI LIB: Fix rsmiBindings.py.in Mismatch This commit aligns the rsmiBindings.py.in file's "notification_type_names" & "rsmi_evt_notification_type_t" with those found in the rsmiBindings.py file. Change-Id: I67f36606c505992fb98495651310bd70a1755033 Signed-off-by: Ori Messinger [ROCm/rocm_smi_lib commit: 0c48cd9122d2b685185a5b921c0e55a90ac24dc2] --- projects/rocm-smi-lib/CHANGELOG.md | 23 +++++++++++++++++++ .../rocm-smi-lib/include/rocm_smi/rocm_smi.h | 1 + .../python_smi_tools/rsmiBindings.py | 2 +- .../python_smi_tools/rsmiBindings.py.in | 3 ++- 4 files changed, 27 insertions(+), 2 deletions(-) diff --git a/projects/rocm-smi-lib/CHANGELOG.md b/projects/rocm-smi-lib/CHANGELOG.md index 1ed65dd85d..9ece6ec90e 100644 --- a/projects/rocm-smi-lib/CHANGELOG.md +++ b/projects/rocm-smi-lib/CHANGELOG.md @@ -4,6 +4,29 @@ Full documentation for rocm_smi_lib is available at [https://rocm.docs.amd.com/] ***All information listed below is for reference and subject to change.*** +## rocm_smi_lib for ROCm 6.1.2 + +### Added + +- **Added Ring Hang event** +Added `RSMI_EVT_NOTIF_RING_HANG` to the possible events in the `rsmi_evt_notification_type_t` enum. + +### Changed + +- N/A + +### Optimized + +- N/A + +### Fixed + +- N/A + +### Known Issues + +- N/A + ## rocm_smi_lib for ROCm 6.1.1 ### Added diff --git a/projects/rocm-smi-lib/include/rocm_smi/rocm_smi.h b/projects/rocm-smi-lib/include/rocm_smi/rocm_smi.h index d82a21d330..cfbc9ae64b 100755 --- a/projects/rocm-smi-lib/include/rocm_smi/rocm_smi.h +++ b/projects/rocm-smi-lib/include/rocm_smi/rocm_smi.h @@ -311,6 +311,7 @@ typedef struct { * Event notification event types */ typedef enum { + RSMI_EVT_NOTIF_NONE = KFD_SMI_EVENT_NONE, //!< Unused RSMI_EVT_NOTIF_VMFAULT = KFD_SMI_EVENT_VMFAULT, //!< VM page fault RSMI_EVT_NOTIF_FIRST = RSMI_EVT_NOTIF_VMFAULT, RSMI_EVT_NOTIF_THERMAL_THROTTLE = KFD_SMI_EVENT_THERMAL_THROTTLE, diff --git a/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py b/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py index 3dfab10feb..873051404c 100644 --- a/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py +++ b/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py @@ -107,8 +107,8 @@ notification_type_names = ['VM_FAULT', 'THERMAL_THROTTLE', 'GPU_PRE_RESET', 'GPU class rsmi_evt_notification_type_t(c_int): RSMI_EVT_NOTIF_NONE = 0 - RSMI_EVT_NOTIF_FIRST = RSMI_EVT_NOTIF_NONE RSMI_EVT_NOTIF_VMFAULT = 1 + RSMI_EVT_NOTIF_FIRST = RSMI_EVT_NOTIF_VMFAULT RSMI_EVT_NOTIF_THERMAL_THROTTLE = 2 RSMI_EVT_NOTIF_GPU_PRE_RESET = 3 RSMI_EVT_NOTIF_GPU_POST_RESET = 4 diff --git a/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py.in b/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py.in index b24665cf9a..18a8535867 100644 --- a/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py.in +++ b/projects/rocm-smi-lib/python_smi_tools/rsmiBindings.py.in @@ -134,10 +134,11 @@ class rsmi_dev_perf_level_t(c_int): RSMI_DEV_PERF_LEVEL_UNKNOWN = 0x100 -notification_type_names = ['VM_FAULT', 'THERMAL_THROTTLE', 'GPU_RESET'] +notification_type_names = ['VM_FAULT', 'THERMAL_THROTTLE', 'GPU_PRE_RESET', 'GPU_POST_RESET', 'RING_HANG'] class rsmi_evt_notification_type_t(c_int): + RSMI_EVT_NOTIF_NONE = 0 RSMI_EVT_NOTIF_VMFAULT = 1 RSMI_EVT_NOTIF_FIRST = RSMI_EVT_NOTIF_VMFAULT RSMI_EVT_NOTIF_THERMAL_THROTTLE = 2