From 039ea82777df665645ae630c51572958bd963903 Mon Sep 17 00:00:00 2001
From: Brandon Potter <brandon.potter@amd.com>
Date: Mon, 12 Aug 2024 14:37:47 -0700
Subject: [PATCH] Change read/write to load/store in Nofitier API

---
 src/memory/notifier.hpp             | 4 ++--
 src/memory/slab_heap.cpp            | 4 ++--
 tests/unit_tests/notifier_gtest.hpp | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/memory/notifier.hpp b/src/memory/notifier.hpp
index e6364a26cf..b2211f0cc5 100644
--- a/src/memory/notifier.hpp
+++ b/src/memory/notifier.hpp
@@ -32,11 +32,11 @@ namespace rocshmem {
 template<detail::atomic::rocshmem_memory_scope scope>
 class Notifier {
  public:
-  __device__ uint64_t read() {
+  __device__ uint64_t load() {
       return detail::atomic::load<uint64_t, scope>(&value_, orders);
   }
 
-  __device__ void write(uint64_t val) {
+  __device__ void store(uint64_t val) {
       detail::atomic::store<uint64_t, scope>(&value_, val, orders);
   }
 
diff --git a/src/memory/slab_heap.cpp b/src/memory/slab_heap.cpp
index 89067b78da..80b8a8cef9 100644
--- a/src/memory/slab_heap.cpp
+++ b/src/memory/slab_heap.cpp
@@ -75,8 +75,8 @@ __device__ void SlabHeap::malloc(void** ptr, size_t size) {
    * Notify other threads in block about the allocation result.
    */
   auto notifier{notifier_.get()};
-  notifier->write(ptr_deref_u64);
-  uint64_t notification_u64{notifier->read()};
+  notifier->store(ptr_deref_u64);
+  uint64_t notification_u64{notifier->load()};
   notifier->done();
 
   /*
diff --git a/tests/unit_tests/notifier_gtest.hpp b/tests/unit_tests/notifier_gtest.hpp
index 4a72212f5d..b914ca4f22 100644
--- a/tests/unit_tests/notifier_gtest.hpp
+++ b/tests/unit_tests/notifier_gtest.hpp
@@ -53,8 +53,8 @@ __global__
 void
 all_threads_once(uint8_t* raw_memory,
                  Notifier<detail::atomic::memory_scope_workgroup> * notifier) {
-    notifier->write(NOTIFIER_OFFSET);
-    uint64_t offset_u64 {notifier->read()};
+    notifier->store(NOTIFIER_OFFSET);
+    uint64_t offset_u64 {notifier->load()};
     notifier->done();
 
     uint64_t raw_memory_u64 {reinterpret_cast<uint64_t>(raw_memory)};