AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-221166 - Detect support for large bar access through HIP runtime API

Browse Source 
Change-Id: Iaa9756c1b5e40c1ab5afb38e44a6699fa5f6c13f
This commit is contained in:
Alex Xie
2020-04-30 22:19:15 -04:00
committed by AlexBin Xie
parent a94de6d463
commit 044a7e55ad
5 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hipamd/include/hip/hip_runtime_api.h
+1 -1
View File
@@ -136,7 +136,7 @@ typedef struct hipDeviceProp_t {
///devices with unmatched block dimensions ///devices with unmatched block dimensions
int cooperativeMultiDeviceUnmatchedSharedMem; ///< HIP device supports cooperative launch on multiple int cooperativeMultiDeviceUnmatchedSharedMem; ///< HIP device supports cooperative launch on multiple
///devices with unmatched shared memories ///devices with unmatched shared memories
int isLargeBar; ///< 1: if it is a large PCI bar device, else 0
} hipDeviceProp_t; } hipDeviceProp_t;
hipamd/samples/1_Utils/hipInfo/hipInfo.cpp
+1
View File
@@ -146,6 +146,7 @@ void printDeviceProp(int deviceId) {
cout << setw(w1) << "maxTexture3D.width: " << props.maxTexture3D[0] << endl; cout << setw(w1) << "maxTexture3D.width: " << props.maxTexture3D[0] << endl;
cout << setw(w1) << "maxTexture3D.height: " << props.maxTexture3D[1] << endl; cout << setw(w1) << "maxTexture3D.height: " << props.maxTexture3D[1] << endl;
cout << setw(w1) << "maxTexture3D.depth: " << props.maxTexture3D[2] << endl; cout << setw(w1) << "maxTexture3D.depth: " << props.maxTexture3D[2] << endl;
cout << setw(w1) << "isLargeBar: " << props.isLargeBar << endl;
int deviceCnt; int deviceCnt;
hipGetDeviceCount(&deviceCnt); hipGetDeviceCount(&deviceCnt);
hipamd/src/hip_hcc.cpp
+1 -1
View File
@@ -864,7 +864,7 @@ hipError_t ihipDevice_t::initProperties(hipDeviceProp_t* prop) {
/* Computemode for HSA Devices is always : cudaComputeModeDefault */ /* Computemode for HSA Devices is always : cudaComputeModeDefault */
prop->computeMode = 0; prop->computeMode = 0;
_isLargeBar = _acc.has_cpu_accessible_am(); prop->isLargeBar = _acc.has_cpu_accessible_am() ? 1 : 0;
// Get Max Threads Per Multiprocessor // Get Max Threads Per Multiprocessor
uint32_t max_waves_per_cu; uint32_t max_waves_per_cu;
hipamd/src/hip_hcc_internal.h
-3
View File
@@ -836,9 +836,6 @@ class ihipDevice_t {
unsigned _computeUnits; unsigned _computeUnits;
hipDeviceProp_t _props; // saved device properties. hipDeviceProp_t _props; // saved device properties.
// TODO - report this through device properties, base on HCC API call.
int _isLargeBar;
// Node id reported by kfd for this device // Node id reported by kfd for this device
uint32_t _driver_node_id; uint32_t _driver_node_id;
hipamd/vdi/hip_device.cpp
+1
View File
@@ -230,6 +230,7 @@ hipError_t hipGetDeviceProperties ( hipDeviceProp_t* props, hipDevice_t device )
deviceProps.texturePitchAlignment = info.imagePitchAlignment_; deviceProps.texturePitchAlignment = info.imagePitchAlignment_;
deviceProps.kernelExecTimeoutEnabled = 0; deviceProps.kernelExecTimeoutEnabled = 0;
deviceProps.ECCEnabled = info.errorCorrectionSupport_? 1:0; deviceProps.ECCEnabled = info.errorCorrectionSupport_? 1:0;
deviceProps.isLargeBar = info.largeBar_ ? 1 : 0;
*props = deviceProps; *props = deviceProps;
HIP_RETURN(hipSuccess); HIP_RETURN(hipSuccess);