From 04d62f3fb61d4d99414842afe336165145a1be96 Mon Sep 17 00:00:00 2001 From: Michael LIAO Date: Mon, 6 Apr 2020 12:16:07 -0400 Subject: [PATCH] [vdi] Fix `-Wsign-compare` warning. NFC. - TeamCity build failed as `-Werror` is turned on. Change-Id: Icd2cbd45f60e3c296894e8e73685e1d177f125a8 [ROCm/clr commit: 679f49c9049dbd1628eb5c850ae00b5188ea23c0] --- projects/clr/hipamd/vdi/hip_module.cpp | 2 +- projects/clr/hipamd/vdi/hip_platform.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/clr/hipamd/vdi/hip_module.cpp b/projects/clr/hipamd/vdi/hip_module.cpp index 75639b39f4..599ebbef80 100755 --- a/projects/clr/hipamd/vdi/hip_module.cpp +++ b/projects/clr/hipamd/vdi/hip_module.cpp @@ -309,7 +309,7 @@ hipError_t ihipModuleLaunchKernel(hipFunction_t f, int block_size = blockDimX * blockDimY * blockDimZ; hip_impl::ihipOccupancyMaxActiveBlocksPerMultiprocessor( &num_blocks, &num_grids, device, f, block_size, sharedMemBytes, true); - if (((gridDimX * gridDimY * gridDimZ) / block_size) > num_grids) { + if (((gridDimX * gridDimY * gridDimZ) / block_size) > unsigned(num_grids)) { return hipErrorCooperativeLaunchTooLarge; } } diff --git a/projects/clr/hipamd/vdi/hip_platform.cpp b/projects/clr/hipamd/vdi/hip_platform.cpp index b3998d4e95..5ece473e06 100755 --- a/projects/clr/hipamd/vdi/hip_platform.cpp +++ b/projects/clr/hipamd/vdi/hip_platform.cpp @@ -732,7 +732,7 @@ hipError_t ihipOccupancyMaxActiveBlocksPerMultiprocessor( } // Make sure the requested block size is smaller than max supported - if (blockSize > device.info().maxWorkGroupSize_) { + if (blockSize > int(device.info().maxWorkGroupSize_)) { numBlocks = 0; numGrids = 0; return hipSuccess;