SWDEV-301667 - Logging refactor

- Remove newline from logging as log function internally inserts a new
line

Change-Id: I25eb2242a1f1e87cf811bcc373d1d485b2e027a8
This commit is contained in:
Saleel Kudchadker
2023-12-07 01:32:20 +00:00
rodzic 59a6a6c12e
commit 058b2702db
16 zmienionych plików z 77 dodań i 78 usunięć
+11 -11
Wyświetl plik
@@ -54,13 +54,13 @@ void setupGLInteropOnce() {
amd::Context::Info info;
if (CL_SUCCESS != amd::Context::checkProperties(properties, &info)) {
LogError("Context setup failed \n");
LogError("Context setup failed");
return;
}
amdContext->setInfo(info);
if (CL_SUCCESS != amdContext->create(properties)) {
LogError("Context setup failed \n");
LogError("Context setup failed");
}
}
@@ -96,11 +96,11 @@ hipError_t hipGLGetDevices(unsigned int* pHipDeviceCount, int* pHipDevices,
static const bool VALIDATE_ONLY = true;
if (deviceList == hipGLDeviceListNextFrame) {
LogError(" hipGLDeviceListNextFrame not supported yet.\n");
LogError(" hipGLDeviceListNextFrame not supported yet");
HIP_RETURN(hipErrorNotSupported);
}
if (pHipDeviceCount == nullptr || pHipDevices == nullptr || hipDeviceCount == 0) {
LogError(" Invalid Argument \n");
LogError(" Invalid Argument");
HIP_RETURN(hipErrorInvalidValue);
}
@@ -108,7 +108,7 @@ hipError_t hipGLGetDevices(unsigned int* pHipDeviceCount, int* pHipDevices,
amd::Context::Info info = hip::getCurrentDevice()->asContext()->info();
if (!(info.flags_ & amd::Context::GLDeviceKhr)) {
LogError("Failed : Invalid Shared Group Reference \n");
LogError("Failed : Invalid Shared Group Reference");
HIP_RETURN(hipErrorInvalidValue);
}
amd::GLFunctions* glenv = hip::getCurrentDevice()->asContext()->glenv();
@@ -248,7 +248,7 @@ hipError_t hipGraphicsGLRegisterImage(hipGraphicsResource** resource, GLuint ima
amd::GLFunctions::SetIntEnv ie(amdContext.glenv());
if (!ie.isValid()) {
LogWarning("\"amdContext\" is not created from GL context or share list \n");
LogWarning("\"amdContext\" is not created from GL context or share list");
HIP_RETURN(hipErrorUnknown);
}
@@ -516,7 +516,7 @@ hipError_t hipGraphicsGLRegisterImage(hipGraphicsResource** resource, GLuint ima
assert(amdContext.devices().size() == 1);
const amd::Device& dev = *(amdContext.devices()[0]);
device::Memory* mem = pImageGL->getDeviceMemory(dev);
if (nullptr == mem) {
LogPrintfError("Can't allocate memory size - 0x%08X bytes!", pImageGL->getSize());
@@ -562,7 +562,7 @@ hipError_t hipGraphicsGLRegisterBuffer(hipGraphicsResource** resource, GLuint bu
{
amd::GLFunctions::SetIntEnv ie(amdContext.glenv());
if (!ie.isValid()) {
LogWarning("\"amdContext\" is not created from GL context or share list \n");
LogWarning("\"amdContext\" is not created from GL context or share list");
HIP_RETURN(hipErrorUnknown);
}
@@ -570,7 +570,7 @@ hipError_t hipGraphicsGLRegisterBuffer(hipGraphicsResource** resource, GLuint bu
clearGLErrors(amdContext);
if ((GL_FALSE == amdContext.glenv()->glIsBuffer_(buffer)) ||
(GL_NO_ERROR != (glErr = amdContext.glenv()->glGetError_()))) {
LogWarning("\"buffer\" is not a GL buffer object \n");
LogWarning("\"buffer\" is not a GL buffer object");
HIP_RETURN(hipErrorInvalidResourceHandle);
}
@@ -579,11 +579,11 @@ hipError_t hipGraphicsGLRegisterBuffer(hipGraphicsResource** resource, GLuint bu
clearGLErrors(amdContext);
amdContext.glenv()->glGetBufferParameteriv_(glTarget, GL_BUFFER_SIZE, &gliSize);
if (GL_NO_ERROR != (glErr = amdContext.glenv()->glGetError_())) {
LogWarning("cannot get the GL buffer size \n");
LogWarning("cannot get the GL buffer size");
HIP_RETURN(hipErrorInvalidResourceHandle);
}
if (gliSize == 0) {
LogWarning("the GL buffer's data store is not created \n");
LogWarning("the GL buffer's data store is not created");
HIP_RETURN(hipErrorInvalidResourceHandle);
}