From 05aba003c965995d5858aa74fda9ddfb993e8427 Mon Sep 17 00:00:00 2001 From: jamessiddeley-amd Date: Thu, 12 Jun 2025 17:03:48 -0400 Subject: [PATCH] Fix: Add explicit includes for assert.h and thread in sample files (#751) * Fix: Add explicit includes for assert.h and thread in sample/vcopy.cpp The HIP/CLR change e3cb5399c removed transitive inclusion of standard headers like assert.h from hip_runtime.h. This caused build failures in rocprof-compute samples. This commit explicitly includes and in vcopy.cpp to resolve potential missing definitions. Signed-off-by: jamessiddeley-amd * Update vsequential_access.cpp Added assert and thread imports Signed-off-by: jamessiddeley-amd * Update vrandom_access.cpp Added assert import Signed-off-by: jamessiddeley-amd * Update vsequential_access.cpp Signed-off-by: jamessiddeley-amd --------- Signed-off-by: jamessiddeley-amd [ROCm/rocprofiler-compute commit: 667128e3c7c6f0ece634771172fed27e98385d4b] --- projects/rocprofiler-compute/sample/vcopy.cpp | 2 ++ projects/rocprofiler-compute/sample/vrandom_access.cpp | 1 + projects/rocprofiler-compute/sample/vsequential_access.cpp | 1 + 3 files changed, 4 insertions(+) diff --git a/projects/rocprofiler-compute/sample/vcopy.cpp b/projects/rocprofiler-compute/sample/vcopy.cpp index fd388c37bb..855c2f4a85 100644 --- a/projects/rocprofiler-compute/sample/vcopy.cpp +++ b/projects/rocprofiler-compute/sample/vcopy.cpp @@ -25,6 +25,8 @@ */ #include "hip/hip_runtime.h" +#include +#include #include #include #include diff --git a/projects/rocprofiler-compute/sample/vrandom_access.cpp b/projects/rocprofiler-compute/sample/vrandom_access.cpp index 3fddb549fa..cabe782802 100644 --- a/projects/rocprofiler-compute/sample/vrandom_access.cpp +++ b/projects/rocprofiler-compute/sample/vrandom_access.cpp @@ -30,6 +30,7 @@ An example code to execute random access to explore cache hits/misses in L2 Cach #include +#include #include #include #include diff --git a/projects/rocprofiler-compute/sample/vsequential_access.cpp b/projects/rocprofiler-compute/sample/vsequential_access.cpp index 3d1d3f66a9..b8f4c1f726 100644 --- a/projects/rocprofiler-compute/sample/vsequential_access.cpp +++ b/projects/rocprofiler-compute/sample/vsequential_access.cpp @@ -31,6 +31,7 @@ An example code to execute sequential access to explore cache hits/misses in L2 #include #include +#include #define HIP_ASSERT(x) (assert((x)==hipSuccess))