From 05e927bcb00daa9893e589b9118d8da466b218c6 Mon Sep 17 00:00:00 2001 From: Apurv Mishra Date: Wed, 27 Nov 2024 16:58:56 -0500 Subject: [PATCH] hsakmt: minor code cleanup and refactor topology.c removed unused value assignment for HSAKMT_STATUS, restructured 'topology_sysfs_check_node_supported' Change-Id: I21cdccb3e3c5e42981f10597426de479d0f4ee6a Signed-off-by: Apurv Mishra [ROCm/ROCR-Runtime commit: 79f0ac2534212a78859ba24c30b4db80c7a94f9d] --- projects/rocr-runtime/libhsakmt/src/topology.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/projects/rocr-runtime/libhsakmt/src/topology.c b/projects/rocr-runtime/libhsakmt/src/topology.c index 9990286aae..751305054b 100644 --- a/projects/rocr-runtime/libhsakmt/src/topology.c +++ b/projects/rocr-runtime/libhsakmt/src/topology.c @@ -669,8 +669,8 @@ static HSAKMT_STATUS topology_sysfs_check_node_supported(uint32_t sysfs_node_id, snprintf(path, 256, "%s/%d/properties", KFD_SYSFS_PATH_NODES, sysfs_node_id); fd = fopen(path, "r"); if (!fd) { - ret = HSAKMT_STATUS_ERROR; - goto err; + free(read_buf); + return HSAKMT_STATUS_ERROR; } read_size = fread(read_buf, 1, PAGE_SIZE, fd); @@ -2065,7 +2065,6 @@ retry: ret = topology_sysfs_get_iolink_props(i, sys_link_id++, &temp_props[i].link[link_id], true); if (ret == HSAKMT_STATUS_NOT_SUPPORTED) { - ret = HSAKMT_STATUS_SUCCESS; continue; } else if (ret != HSAKMT_STATUS_SUCCESS) { free_properties(temp_props, i + 1); @@ -2115,7 +2114,7 @@ err: return ret; } -/* Drop the Snashot of the HSA topology information. Assume lock is held. */ +/* Drop the Snapshot of the HSA topology information. Assume lock is held. */ void topology_drop_snapshot(void) { if (!!g_system != !!g_props)