AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-403995 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options.

Browse Source 
Change-Id: Ife45c1e3ccef03d16d7e07c3e0714fd8fd388fd3


[ROCm/clr commit: 2c9c58e7bb]
This commit is contained in:
Jaydeep Patel
2023-06-05 14:42:14 +00:00
committed by Jaydeepkumar Patel
parent cea26614db
commit 063b3d4e51
3 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/rocclr/device/devkernel.cpp
+1 -1
View File
@@ -570,7 +570,7 @@ static amd_comgr_status_t populateKernelMetaV3(const amd_comgr_metadata_node_t k
kernel->SetWGPMode(buf.compare("true") == 0); kernel->SetWGPMode(buf.compare("true") == 0);
break; break;
case KernelField::UniformWrokGroupSize: case KernelField::UniformWrokGroupSize:
kernel->setUniformWorkGroupSize(buf.compare("true") == 0); kernel->setUniformWorkGroupSize(buf.compare("1") == 0);
break; break;
default: default:
return AMD_COMGR_STATUS_ERROR; return AMD_COMGR_STATUS_ERROR;
projects/clr/rocclr/device/pal/palprogram.cpp
+3 -2
View File
@@ -748,8 +748,9 @@ bool LightningProgram::createKernels(void* binary, size_t binSize, bool useUnifo
return false; return false;
} }
kernels()[kernelName] = kernel; kernels()[kernelName] = kernel;
if (codeObjectVer() < 5) {
kernel->setUniformWorkGroupSize(useUniformWorkGroupSize); kernel->setUniformWorkGroupSize(useUniformWorkGroupSize);
}
} }
executable_ = loader_->CreateExecutable(HSA_PROFILE_FULL, nullptr); executable_ = loader_->CreateExecutable(HSA_PROFILE_FULL, nullptr);
projects/clr/rocclr/device/rocm/rocprogram.cpp
+3 -1
View File
@@ -274,7 +274,9 @@ bool LightningProgram::createKernels(void* binary, size_t binSize, bool useUnifo
if (!aKernel->init()) { if (!aKernel->init()) {
return false; return false;
} }
aKernel->setUniformWorkGroupSize(useUniformWorkGroupSize); if (codeObjectVer() < 5) {
aKernel->setUniformWorkGroupSize(useUniformWorkGroupSize);
}
aKernel->setInternalKernelFlag(internalKernel); aKernel->setInternalKernelFlag(internalKernel);
kernels()[kernelName] = aKernel; kernels()[kernelName] = aKernel;
} }