Re-enable clang-tidy for core workflows + clang-tidy fixes (#197)

* Ensure the clang-tidy is updated + clang-tidy fixes

* update-ci workflow

* Enable clang-tidy checks

* Add extra logging to device counter collection samples

* Misc clang-tidy fixes

* Disable device counter collection samples for ThreadSanitizer

* Formatting

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

source/lib/output/generateCSV.cpp

@@ -585,7 +585,7 @@ generate_csv(const output_config&                    cfg,
 
     for(auto ditr : data)
     {
-        for(auto record : data.get(ditr))
+        for(const auto& record : data.get(ditr))
         {
             auto kernel_id        = record.dispatch_data.dispatch_info.kernel_id;
             auto counter_id_value = std::map<rocprofiler_counter_id_t, double>{};