AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-521647 - Fix tracking of hw_event (#206)

Browse Source 
- When a command may possibly have two packets(like device heap
  initializer), and if there is no signal on the main kernel packet the
tracking was broken as it marked HW event of the command as the first
packet signal.
- Make sure if no completion signal is attached to the second packet
  then clear the HW event for the command.
This commit is contained in:
Kudchadker, Saleel
2025-04-25 08:46:44 -07:00
committed by GitHub
parent ce24936970
commit 072fb0804e
5 changed files with 39 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rocclr/platform/command.cpp
+2 -4
View File
@@ -277,7 +277,6 @@ bool Event::notifyCmdQueue(bool cpu_wait) {
notified_.clear();
return false;
}
ClPrint(LOG_DEBUG, LOG_CMD, "Queue marker to command queue: %p", queue);
command->enqueue();
// Save notification, associated with the current event
notify_event_ = command;
@@ -290,7 +289,6 @@ bool Event::notifyCmdQueue(bool cpu_wait) {
notified_.clear();
return false;
}
ClPrint(LOG_DEBUG, LOG_CMD, "Queue marker to command queue: %p", queue);
command->enqueue();
command->release();
}
@@ -356,8 +354,8 @@ void Command::enqueue() {
Agent::postEventCreate(as_cl(static_cast<Event*>(this)), type_);
}
ClPrint(LOG_DEBUG, LOG_CMD, "Command (%s) enqueued: %p",
amd::activity_prof::getOclCommandKindString(this->type()), this);
ClPrint(LOG_DEBUG, LOG_CMD, "Command (%s) enqueued: %p to queue: %p",
amd::activity_prof::getOclCommandKindString(this->type()), this, queue_);
// Direct dispatch logic below will submit the command immediately, but the command status
// update will occur later after flush() with a wait