AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-340226 - SWDEV-340692 - Fix minor issues with hiprtc Link APIs

Browse Source 
- hiprtcAddLinkData should accept 0 or null as input name
- hiprtcLinkCreate should accept 0 or null as options ptr
- hiprtcCompile should send -fgpu-rdc option to comgr if its present in the options

Change-Id: I84f6e36df5c99b719ee9c67dfc1b4dbcfd8e3172


[ROCm/clr commit: ee27685ac4]
This commit is contained in:
Satyanvesh Dittakavi
2022-07-21 14:45:45 +00:00
parent 020a8dcede
commit 0886b8ad06
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/hipamd/src/hiprtc/hiprtc.cpp
+8 -4
View File
@@ -112,11 +112,10 @@ hiprtcResult hiprtcCompileProgram(hiprtcProgram prog, int numOptions, const char
std::vector<std::string> opt;
opt.reserve(numOptions);
for (int i = 0; i < numOptions; i++) {
if(std::string(options[i]) == std::string("-fgpu-rdc")) {
if (std::string(options[i]) == std::string("-fgpu-rdc")) {
fgpu_rdc = true;
} else {
opt.push_back(std::string(options[i]));
}
opt.push_back(std::string(options[i]));
}
if (!rtcProgram->compile(opt, fgpu_rdc)) {
@@ -317,9 +316,14 @@ hiprtcResult hiprtcLinkAddData(hiprtcLinkState hip_link_state, hiprtcJITInputTyp
HIPRTC_RETURN(HIPRTC_ERROR_INVALID_INPUT);
}
std::string input_name;
if (name) {
input_name = name;
}
hiprtc::RTCLinkProgram* rtc_link_prog_ptr
= reinterpret_cast<hiprtc::RTCLinkProgram*>(hip_link_state);
if (!rtc_link_prog_ptr->AddLinkerData(image, image_size, name, input_type)) {
if (!rtc_link_prog_ptr->AddLinkerData(image, image_size, input_name, input_type)) {
HIPRTC_RETURN(HIPRTC_ERROR_PROGRAM_CREATION_FAILURE);
}