SWDEV-403050: Multiple fixes for Memory Leaks in profiler

Change-Id: Ib720a81105af13898ff745ce0cbc2a48c1f4a980

src/core/session/profiler/profiler.cpp

@@ -50,8 +50,17 @@ uint64_t GetCounterID(std::string& counter_name) {
 
 Profiler::Profiler(rocprofiler_buffer_id_t buffer_id, rocprofiler_filter_id_t filter_id,
                    rocprofiler_session_id_t session_id)
-    : buffer_id_(buffer_id), filter_id_(filter_id), session_id_(session_id) {}
-Profiler::~Profiler() {}
+    : buffer_id_(buffer_id), filter_id_(filter_id), session_id_(session_id) {
+  sessions_pending_signals_ = new std::map<uint32_t, std::vector<pending_signal_t*>>();
+}
+Profiler::~Profiler() {
+  for (auto& [thread_id, pending_signals] : *sessions_pending_signals_) {
+    for (auto& pending_signal : pending_signals) {
+      delete pending_signal;
+    }
+  }
+  delete sessions_pending_signals_;
+}
 
 void Profiler::AddCounterName(rocprofiler_counter_id_t counter_id, std::string counter_name) {
   std::lock_guard<std::mutex> lock(counter_names_lock_);
@@ -106,39 +115,39 @@ const char* Profiler::GetCounterInfo(rocprofiler_counter_info_kind_t kind,
   return nullptr;
 }
 
-void Profiler::StartReplayPass(rocprofiler_session_id_t session_id) { warning("Not yet supported!"); }
+void Profiler::StartReplayPass(rocprofiler_session_id_t session_id) {
+  warning("Not yet supported!");
+}
 void Profiler::EndReplayPass() { warning("Not yet supported!"); }
 bool Profiler::HasActivePass() {
   warning("Not yet supported!");
   return true;
 }
 
-void Profiler::AddPendingSignals(uint32_t writer_id, uint64_t kernel_object,
-                                 const hsa_signal_t& completion_signal,
-                                 rocprofiler_session_id_t session_id, rocprofiler_buffer_id_t buffer_id,
-                                 rocmtools::profiling_context_t* context,
-                                 uint64_t session_data_count,
-                                 hsa_ven_amd_aqlprofile_profile_t* profile,
-                                 rocprofiler_kernel_properties_t kernel_properties,
-                                 uint32_t thread_id, uint64_t queue_index) {
+void Profiler::AddPendingSignals(
+    uint32_t writer_id, uint64_t kernel_object, const hsa_signal_t& completion_signal,
+    rocprofiler_session_id_t session_id, rocprofiler_buffer_id_t buffer_id,
+    rocmtools::profiling_context_t* context, uint64_t session_data_count,
+    hsa_ven_amd_aqlprofile_profile_t* profile, rocprofiler_kernel_properties_t kernel_properties,
+    uint32_t thread_id, uint64_t queue_index, uint64_t correlation_id) {
   std::lock_guard<std::mutex> lock(sessions_pending_signals_lock_);
-  if (sessions_pending_signals_.find(writer_id) == sessions_pending_signals_.end())
-    sessions_pending_signals_.emplace(writer_id, std::vector<pending_signal_t>());
-  sessions_pending_signals_.at(writer_id).emplace_back(
-      pending_signal_t{kernel_object, completion_signal, session_id_, buffer_id, context,
-                       session_data_count, profile, kernel_properties, thread_id, queue_index});
+  if (sessions_pending_signals_->find(writer_id) == sessions_pending_signals_->end())
+    sessions_pending_signals_->emplace(writer_id, std::vector<pending_signal_t*>());
+  sessions_pending_signals_->at(writer_id).emplace_back(new pending_signal_t{
+      kernel_object, completion_signal, session_id_, buffer_id, context, session_data_count,
+      profile, kernel_properties, thread_id, queue_index, correlation_id});
 }
 
-const std::vector<pending_signal_t>& Profiler::GetPendingSignals(uint32_t writer_id) {
+const std::vector<pending_signal_t*>& Profiler::GetPendingSignals(uint32_t writer_id) {
   std::lock_guard<std::mutex> lock(sessions_pending_signals_lock_);
-  assert(sessions_pending_signals_.find(writer_id) != sessions_pending_signals_.end() &&
+  assert(sessions_pending_signals_->find(writer_id) != sessions_pending_signals_->end() &&
          "writer_id is not found in the pending_signals");
-  return sessions_pending_signals_.at(writer_id);
+  return sessions_pending_signals_->at(writer_id);
 }
 
 bool Profiler::CheckPendingSignalsIsEmpty() {
   std::lock_guard<std::mutex> lock(sessions_pending_signals_lock_);
-  return sessions_pending_signals_.empty();
+  return sessions_pending_signals_->empty();
 }
 
 }  // namespace profiler