Gbaraldi/att tool (#766)

* Enabling codeobj and thread trace samples * Updating aqlprofile_v2 header * Codeobj and thread trace samples with output log files * Fixing clang format * Cmake formatting * Adding coverage to codeobj * Comment trace sample * Adding ATT Parser API * Fixing forwarding to aqlprofile * Clang formatting * Clang tidy * Adding option to print memory kernels * Clang format * Remove default from switch case * Separating client/main on codeobj sample for ASAn * Formatting * Gbaraldi/att tool rebase (#801) * Enabling codeobj and thread trace samples * Updating aqlprofile_v2 header * Codeobj and thread trace samples with output log files * Fixing clang format * Cmake formatting * Adding coverage to codeobj * Comment trace sample * Removing python from workflow * Adding ATT Parser API * Fixing forwarding to aqlprofile * Clang formatting * Clang tidy * Adding option to print memory kernels * Clang format * Remove default from switch case * Separating client/main on codeobj sample for ASAn * Formatting * Enabling codeobj and thread trace samples * Updating aqlprofile_v2 header * Codeobj and thread trace samples with output log files * Fixing clang format * Cmake formatting * Adding coverage to codeobj * Comment trace sample * Adding ATT Parser API * Fixing forwarding to aqlprofile * Clang formatting * Clang tidy * Adding option to print memory kernels * Clang format * Remove default from switch case * Separating client/main on codeobj sample for ASAn * Formatting * Fix codeobj library * Allow thread trace in parallel with other service * Zeroing the HSA signals * Adding exception wrappers in ATT sample * Removed force configure * Remove force configure from ISA decode * Removing codecov flag * Gbaraldi/att tool tests (#828) * Adding tests for codeobj ISA decode * Adding ATT tests * Adding ATT integration tests * Formatting * Changing codeobj binary extension * Renaming codeobj library spaces * Fixing samples * Formatting * Formatting * Fixing int test * Fixing linker error * Fixing memory fault * Moving kernel ot inside namespace * ASAN linking fix * Removing unecessary headers * Formatting * Fixing target_cu * Remove codeobj binary * Revert "Remove codeobj binary" This reverts commit 7d286f89d8096bc36925cd79cd742a5e6d10d179. * Enable memory snapshot * adding comgr --------- Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com>
2024-05-03 18:45:47 -03:00
@@ -202,10 +202,10 @@ CounterPacketConstruct::construct_packet(const AmdExtTable& ext)
 #pragma GCC diagnostic ignored "-Wnarrowing"

 ThreadTraceAQLPacketFactory::ThreadTraceAQLPacketFactory(
-    const hsa::AgentCache&                    agent,
-    std::shared_ptr<thread_trace_parameters>& params,
-    const CoreApiTable&                       coreapi,
-    const AmdExtTable&                        ext)
+    const hsa::AgentCache&                        agent,
+    std::shared_ptr<thread_trace_parameter_pack>& params,
+    const CoreApiTable&                           coreapi,
+    const AmdExtTable&                            ext)
 {
    this->tracepool                  = std::make_shared<hsa::TraceMemoryPool>();
    this->tracepool->allocate_fn     = ext.hsa_amd_memory_pool_allocate_fn;
@@ -231,20 +231,22 @@ ThreadTraceAQLPacketFactory::ThreadTraceAQLPacketFactory(
 std::unique_ptr<hsa::TraceAQLPacket>
 ThreadTraceAQLPacketFactory::construct_packet()
 {
-    auto packet = std::make_unique<hsa::TraceAQLPacket>(this->tracepool);
-    /*hsa_status_t _status = aqlprofile_att_create_packets(&packet->handle,
+    auto         packet  = std::make_unique<hsa::TraceAQLPacket>(this->tracepool);
+    hsa_status_t _status = aqlprofile_att_create_packets(&packet->handle,
                                                         &packet->packets,
                                                         this->profile,
                                                         &hsa::TraceAQLPacket::Alloc,
                                                         &hsa::TraceAQLPacket::Free,
                                                         &hsa::TraceAQLPacket::Copy,
                                                         packet.get());
-    CHECK_HSA(_status, "failed to create ATT packet");*/
+    CHECK_HSA(_status, "failed to create ATT packet");

    packet->before_krn_pkt.clear();
    packet->after_krn_pkt.clear();
    packet->packets.start_packet.header = HSA_PACKET_TYPE_VENDOR_SPECIFIC << HSA_PACKET_HEADER_TYPE;
    packet->packets.stop_packet.header  = HSA_PACKET_TYPE_VENDOR_SPECIFIC << HSA_PACKET_HEADER_TYPE;
+    packet->packets.start_packet.completion_signal = hsa_signal_t{.handle = 0};
+    packet->packets.stop_packet.completion_signal  = hsa_signal_t{.handle = 0};

    packet->empty = false;
    packet->start = packet->packets.start_packet;