Gbaraldi/att tool (#766)

* Enabling codeobj and thread trace samples * Updating aqlprofile_v2 header * Codeobj and thread trace samples with output log files * Fixing clang format * Cmake formatting * Adding coverage to codeobj * Comment trace sample * Adding ATT Parser API * Fixing forwarding to aqlprofile * Clang formatting * Clang tidy * Adding option to print memory kernels * Clang format * Remove default from switch case * Separating client/main on codeobj sample for ASAn * Formatting * Gbaraldi/att tool rebase (#801) * Enabling codeobj and thread trace samples * Updating aqlprofile_v2 header * Codeobj and thread trace samples with output log files * Fixing clang format * Cmake formatting * Adding coverage to codeobj * Comment trace sample * Removing python from workflow * Adding ATT Parser API * Fixing forwarding to aqlprofile * Clang formatting * Clang tidy * Adding option to print memory kernels * Clang format * Remove default from switch case * Separating client/main on codeobj sample for ASAn * Formatting * Enabling codeobj and thread trace samples * Updating aqlprofile_v2 header * Codeobj and thread trace samples with output log files * Fixing clang format * Cmake formatting * Adding coverage to codeobj * Comment trace sample * Adding ATT Parser API * Fixing forwarding to aqlprofile * Clang formatting * Clang tidy * Adding option to print memory kernels * Clang format * Remove default from switch case * Separating client/main on codeobj sample for ASAn * Formatting * Fix codeobj library * Allow thread trace in parallel with other service * Zeroing the HSA signals * Adding exception wrappers in ATT sample * Removed force configure * Remove force configure from ISA decode * Removing codecov flag * Gbaraldi/att tool tests (#828) * Adding tests for codeobj ISA decode * Adding ATT tests * Adding ATT integration tests * Formatting * Changing codeobj binary extension * Renaming codeobj library spaces * Fixing samples * Formatting * Formatting * Fixing int test * Fixing linker error * Fixing memory fault * Moving kernel ot inside namespace * ASAN linking fix * Removing unecessary headers * Formatting * Fixing target_cu * Remove codeobj binary * Revert "Remove codeobj binary" This reverts commit 7d286f89d8096bc36925cd79cd742a5e6d10d179. * Enable memory snapshot * adding comgr --------- Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com>
2024-05-03 18:45:47 -03:00
Parent 6d3fbcffad
@@ -20,8 +20,6 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.

-#include "lib/rocprofiler-sdk-codeobj/code_printing.hpp"
-
 #include <algorithm>
 #include <fstream>
 #include <iomanip>
@@ -35,6 +33,8 @@
 #include <unordered_map>
 #include <vector>

+#include <rocprofiler-sdk-codeobj/code_printing.hpp>
+
 #include <cstdarg>
 #include <cstdio>
 #include <cstdlib>
@@ -72,7 +72,13 @@
    }                                                                                              \
    catch(...) { return returndata; }

-CodeobjDecoderComponent::CodeobjDecoderComponent(const char* codeobj_data, uint64_t codeobj_size)
+namespace rocprofiler
+{
+namespace codeobj
+{
+namespace disassembly
+{
+CodeobjDecoderComponent::CodeobjDecoderComponent(const void* codeobj_data, uint64_t codeobj_size)
 {
    m_fd = -1;
 #if defined(_GNU_SOURCE) && defined(MFD_ALLOW_SEALING) && defined(MFD_CLOEXEC)
@@ -87,7 +93,7 @@ CodeobjDecoderComponent::CodeobjDecoderComponent(const char* codeobj_data, uint6
        return;
    }

-    if(size_t size = ::write(m_fd, codeobj_data, codeobj_size); size != codeobj_size)
+    if(size_t size = ::write(m_fd, (const char*) codeobj_data, codeobj_size); size != codeobj_size)
    {
        printf("could not write to the temporary file\n");
        return;
@@ -150,7 +156,7 @@ CodeobjDecoderComponent::CodeobjDecoderComponent(const char* codeobj_data, uint6
    }

    // Can throw
-    disassembly = std::make_unique<DisassemblyInstance>(codeobj_data, codeobj_size);
+    disassembly = std::make_unique<DisassemblyInstance>((const char*) codeobj_data, codeobj_size);
    if(m_line_number_map.size())
    {
        size_t total_size = 0;
@@ -250,7 +256,7 @@ LoadedCodeobjDecoder::add_to_map(uint64_t ld_addr)
    if(!decoder || ld_addr < load_addr) throw std::out_of_range("Addr not in decoder");

    uint64_t voffset = ld_addr - load_addr;
-    auto     faddr   = decoder->disassembly->va2fo(voffset);
+    auto     faddr   = decoder->va2fo(voffset);
    if(!faddr) throw std::out_of_range("Could not find file offset");

    auto shared          = decoder->disassemble_instruction(*faddr, voffset);
@@ -275,4 +281,6 @@ LoadedCodeobjDecoder::get(uint64_t addr)
    return nullptr;
 }

-#define PUBLIC_API __attribute__((visibility("default")))
+}  // namespace disassembly
+}  // namespace codeobj
+}  // namespace rocprofiler