From 0a45aa85c50ee61dedb99fb6a9b47ec323112cb3 Mon Sep 17 00:00:00 2001 From: "Ramirez, Lucas" Date: Thu, 17 Apr 2025 11:50:07 +0200 Subject: [PATCH] SWDEV-524612 - Consider "1" a truthy value for WGPMode (#187) The compiler currently serializes the workgroup_processor_mode COMGR metadata boolean field as "0"/"1" instead of "false"/"true". Consider "1" a truthy value during parsing. [ROCm/clr commit: d020598a0f79779f752c0c1b8962a7f141db387c] --- projects/clr/rocclr/device/devkernel.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/projects/clr/rocclr/device/devkernel.cpp b/projects/clr/rocclr/device/devkernel.cpp index 9bb6039e33..1bb97cb390 100644 --- a/projects/clr/rocclr/device/devkernel.cpp +++ b/projects/clr/rocclr/device/devkernel.cpp @@ -582,7 +582,9 @@ static amd_comgr_status_t populateKernelMetaV3(const amd_comgr_metadata_node_t k kernel->SetKernelKind(buf); break; case KernelField::WgpMode: - kernel->SetWGPMode(buf.compare("true") == 0); + // The compiler currently serializes this boolean field as "0"/"1" instead + // of "false"/"true"; consider both "true" and "1" truthy values. + kernel->SetWGPMode(buf.compare("true") == 0 || buf.compare("1") == 0); break; case KernelField::UniformWrokGroupSize: kernel->setUniformWorkGroupSize(buf.compare("1") == 0);