From 0b3c8dff0f72fef27745f0755ca79656d934a354 Mon Sep 17 00:00:00 2001 From: Rahul Garg Date: Fri, 17 Jul 2020 19:55:58 +0000 Subject: [PATCH] Handle size 0 symbols Change-Id: Ie282b37cf6bbccae4611dfc17c5c7f31977feea7 [ROCm/hip commit: 0fdec26a2911bfc790afca0de9abc20c5c2e399c] --- projects/hip/rocclr/hip_global.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/projects/hip/rocclr/hip_global.cpp b/projects/hip/rocclr/hip_global.cpp index 2a395fee96..680d16b03f 100755 --- a/projects/hip/rocclr/hip_global.cpp +++ b/projects/hip/rocclr/hip_global.cpp @@ -23,16 +23,18 @@ DeviceVar::DeviceVar(std::string name, hipModule_t hmod) : shadowVptr(nullptr), guarantee(false); } - if (amd_mem_obj_ == nullptr || device_ptr_ == nullptr) { - DevLogPrintfError("Cannot get memory for creating device Var: %s", name.c_str()); - guarantee(false); + // Handle size 0 symbols + if (size_ != 0) { + if (amd_mem_obj_ == nullptr || device_ptr_ == nullptr) { + DevLogPrintfError("Cannot get memory for creating device Var: %s", name.c_str()); + guarantee(false); + } + amd::MemObjMap::AddMemObj(device_ptr_, amd_mem_obj_); } - - amd::MemObjMap::AddMemObj(device_ptr_, amd_mem_obj_); } DeviceVar::~DeviceVar() { - if (device_ptr_ != nullptr) { + if (amd_mem_obj_ != nullptr) { amd::MemObjMap::RemoveMemObj(device_ptr_); amd_mem_obj_->release(); }