From 0c5509e7c37b088311e93994675804d6c9741164 Mon Sep 17 00:00:00 2001 From: Jonathan Kim Date: Wed, 28 Aug 2024 11:13:03 -0400 Subject: [PATCH] libhsakmt: Fix improper type range check in legacy queue creation Enum type for compute AQL is defined as larger then targeted SDMAs enum types. We should only deny legacy calls for SDMA queues that require targeted engines. Change-Id: I6386a8700b3b18af825b6f0d2be27052cc8de0f5 [ROCm/ROCR-Runtime commit: ae99effb290e624bf50927d0bb9c97ba07245804] --- projects/rocr-runtime/libhsakmt/src/queues.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/rocr-runtime/libhsakmt/src/queues.c b/projects/rocr-runtime/libhsakmt/src/queues.c index ec0a214ead..19fc20ffa9 100644 --- a/projects/rocr-runtime/libhsakmt/src/queues.c +++ b/projects/rocr-runtime/libhsakmt/src/queues.c @@ -602,7 +602,7 @@ HSAKMT_STATUS HSAKMTAPI hsaKmtCreateQueue(HSAuint32 NodeId, HsaEvent *Event, HsaQueueResource *QueueResource) { - if (Type >= HSA_QUEUE_SDMA_BY_ENG_ID) + if (Type == HSA_QUEUE_SDMA_BY_ENG_ID) return HSAKMT_STATUS_ERROR; return hsaKmtCreateQueueExt(NodeId, Type, QueuePercentage, Priority, 0,