From 0d4c209552b96965f57f26cc79ff6da17dffca9b Mon Sep 17 00:00:00 2001 From: Kent Russell Date: Wed, 22 Jan 2020 14:42:29 -0500 Subject: [PATCH] Remove RegisterForeignDeviceMem test code Use an "if 0" to remove the code, as it is not working as expected. The test is supposed to test mapping from a foreign device (like a NIC), so it uses a separate GPU to map, but this mapping can be evicted and thus the test can fail unexpectedly. Remove the code until the test can be reworked Change-Id: Ie4a15c2a018bbd8e931b06b6700d10b3be86e410 --- tests/kfdtest/src/KFDGraphicsInterop.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/kfdtest/src/KFDGraphicsInterop.cpp b/tests/kfdtest/src/KFDGraphicsInterop.cpp index 8d97885a30..b5a408534a 100644 --- a/tests/kfdtest/src/KFDGraphicsInterop.cpp +++ b/tests/kfdtest/src/KFDGraphicsInterop.cpp @@ -132,6 +132,12 @@ TEST_F(KFDGraphicsInterop, RegisterGraphicsHandle) { TEST_END } +#if 0 +/* This test isn't testing things the way we wanted it to. It is flaky and + * will end up failing if the memory is evicted, which isn't possible for what + * it is intended to test. It needs a rework + */ + /* Third-party device memory can be registered for GPU access in * ROCm stack. Test this feature. Third party device is mimicked * in multi-GPU system using Graphics stack (libdrm). CPU accessible @@ -222,3 +228,4 @@ TEST_F(KFDGraphicsInterop, RegisterForeignDeviceMem) { TEST_END } +#endif