From 0f7a47a95f3aa6bcd1b9b96efaab85b4e27ffe22 Mon Sep 17 00:00:00 2001 From: Christophe Paquot Date: Fri, 18 Jun 2021 07:03:35 -0700 Subject: [PATCH] SWDEV-281658 - Fix compilation warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In file included from /extra/lmoriche/hip-vdi/hip/rocclr/hip_internal.hpp:25, from /extra/lmoriche/hip-vdi/hip/rocclr/hip_hmm.cpp:22: /extra/lmoriche/hip-vdi/hip/rocclr/hip_prof_api.h: In constructor ‘api_callbacks_table_t::api_callbacks_table_t()’: /extra/lmoriche/hip-vdi/hip/rocclr/hip_prof_api.h:72:59: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct api_callbacks_table_t::hip_cb_table_t’ with no trivial copy-assignment; use value-initialization instead [-Wclass-memaccess] 72 | memset(&callbacks_table_, 0, sizeof(callbacks_table_)); | ^ /extra/lmoriche/hip-vdi/hip/rocclr/hip_prof_api.h:67:10: note: ‘struct api_callbacks_table_t::hip_cb_table_t’ declared here 67 | struct hip_cb_table_t { | ^~~~~~~~~~~~~~ Address the above warning by providing default initialization of the api_callbacks_table_t::hip_cb_table_t class members. Change-Id: I69ea7c390c28cf3f8aec57f23566d6a3061a0365 --- hipamd/src/hip_prof_api.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hipamd/src/hip_prof_api.h b/hipamd/src/hip_prof_api.h index c5d075a68e..c06ffdcd23 100644 --- a/hipamd/src/hip_prof_api.h +++ b/hipamd/src/hip_prof_api.h @@ -56,8 +56,8 @@ class api_callbacks_table_t { // HIP API callbacks table struct hip_cb_table_entry_t { - volatile std::atomic sync; - volatile std::atomic sem; + volatile std::atomic sync{false}; + volatile std::atomic sem{0}; act_t act; void* a_arg; fun_t fun; @@ -65,12 +65,10 @@ class api_callbacks_table_t { }; struct hip_cb_table_t { - hip_cb_table_entry_t arr[HIP_API_ID_NUMBER]; + hip_cb_table_entry_t arr[HIP_API_ID_NUMBER] = {}; }; - api_callbacks_table_t() { - memset(&callbacks_table_, 0, sizeof(callbacks_table_)); - } + api_callbacks_table_t() = default; bool set_activity(uint32_t id, act_t fun, void* arg) { std::lock_guard lock(mutex_);