SWDEV-480772 - Remove name variable from amd::Monitor class.

Change-Id: Ie2a4fa44f485786227230f8a892e090e718aa30e
This commit is contained in:
kjayapra-amd
2024-08-07 18:10:41 -04:00
committed by Karthik Jayaprakash
parent cfdc9dfc36
commit 12a39fbf22
27 changed files with 76 additions and 83 deletions
+4 -2
View File
@@ -301,7 +301,8 @@ std::vector<Device*>* Device::devices_ = nullptr;
AppProfile Device::appProfile_;
Context* Device::glb_ctx_ = nullptr;
Monitor Device::p2p_stage_ops_("P2P Staging Lock", true);
// P2P Staging Lock
Monitor Device::p2p_stage_ops_(true);
Memory* Device::p2p_stage_ = nullptr;
Monitor MemObjMap::AllocatedLock_ ROCCLR_INIT_PRIORITY(101) ("Guards MemObjMap allocation list");
@@ -714,7 +715,8 @@ bool Device::ValidateHsail() {
bool Device::create(const Isa &isa) {
assert(!vaCacheAccess_ && !vaCacheMap_);
isa_ = &isa;
vaCacheAccess_ = new amd::Monitor("VA Cache Ops Lock", true);
// VA Cache Ops Lock
vaCacheAccess_ = new amd::Monitor(true);
if (nullptr == vaCacheAccess_) {
return false;
}
+2 -2
View File
@@ -1265,7 +1265,7 @@ class VirtualDevice : public amd::HeapObject {
VirtualDevice(amd::Device& device)
: device_(device)
, blitMgr_(NULL)
, execution_("Virtual device execution lock", true)
, execution_(true) /* Virtual device execution lock */
, index_(0) {}
//! Destroy this virtual device.
@@ -2156,7 +2156,7 @@ class Device : public RuntimeObject {
uint64_t stack_size_{1024}; //!< Device stack size
device::Memory* initial_heap_buffer_; //!< Initial heap buffer
uint64_t initial_heap_size_{HIP_INITIAL_DM_SIZE}; //!< Initial device heap size
amd::Monitor activeQueuesLock_ {"Guards access to the activeQueues set"};
amd::Monitor activeQueuesLock_ {}; //!< Guards access to the activeQueues set
std::unordered_set<amd::CommandQueue*> activeQueues; //!< The set of active queues
private:
const Isa *isa_; //!< Device isa
+4 -2
View File
@@ -69,7 +69,8 @@ inline static std::vector<std::string> splitSpaceSeparatedString(const char *str
}
#if defined(WITH_COMPILER_LIB)
amd::Monitor Program::buildLock_("HSAIL build lock", true);
// HSAIL build lock
amd::Monitor Program::buildLock_(true);
#endif
// ================================================================================================
@@ -2939,7 +2940,8 @@ bool Program::getGlobalVarFromCodeObj(std::vector<std::string>* var_names) const
#endif
}
amd::Monitor Program::initFiniLock_("Init Fini Launch Lock", true);
// Init Fini Launch Lock
amd::Monitor Program::initFiniLock_(true);
bool Program::runInitFiniKernel(kernel_kind_t kind) const {
amd::HostQueue* queue = nullptr;
+1 -1
View File
@@ -659,7 +659,7 @@ KernelBlitManager::KernelBlitManager(VirtualGPU& gpu, Setup setup)
: DmaBlitManager(gpu, setup),
program_(NULL),
xferBufferSize_(0),
lockXferOps_("Transfer Ops Lock", true) {
lockXferOps_(true) /* Transfer Ops Lock */ {
for (uint i = 0; i < BlitTotal; ++i) {
kernels_[i] = NULL;
}
+7 -7
View File
@@ -803,13 +803,13 @@ Device::ScopedLockVgpus::~ScopedLockVgpus() {
Device::Device()
: NullDevice(),
numOfVgpus_(0),
lockAsyncOps_("Device Async Ops Lock", true),
lockForInitHeap_("Initialization of Heap Resource", true),
lockPAL_("PAL Ops Lock", true),
vgpusAccess_("Virtual GPU List Ops Lock", true),
scratchAlloc_("Scratch Allocation Lock", true),
mapCacheOps_("Map Cache Lock", true),
lockResourceOps_("Resource List Ops Lock", true),
lockAsyncOps_(true), /* Device Async Ops Lock */
lockForInitHeap_(true), /* Initialization of Heap Resource */
lockPAL_(true), /* PAL Ops Lock */
vgpusAccess_(true), /* Virtual GPU List Ops Lock */
scratchAlloc_(true), /* Scratch Allocation Lock */
mapCacheOps_(true), /* Map Cache Lock */
lockResourceOps_(true), /* Resource List Ops Lock */
xferRead_(nullptr),
mapCache_(nullptr),
resourceCache_(nullptr),
+1 -1
View File
@@ -259,7 +259,7 @@ class Device : public NullDevice {
amd::Monitor queue_lock_; //!< Queue lock for access
AqlPacketMgmt aql_packet_mgmt_; //!< AQL packets management class for debugger support
QueueRecycleInfo() : counter_(1), engineType_(Pal::EngineTypeCompute), index_(0),
queue_lock_("Queue lock for sharing", true) {}
queue_lock_(true) /* Queue lock for sharing */ {}
//! Returns the aql packet list
uintptr_t AqlPacketList() const {
+1 -1
View File
@@ -579,7 +579,7 @@ class ResourceCache : public amd::HeapObject {
public:
//! Default constructor
ResourceCache(Device* device, size_t cacheSizeLimit)
: lockCacheOps_("PAL resource cache", true),
: lockCacheOps_(true), /* PAL resource cache */
cacheSize_(0),
lclCacheSize_(0),
persistentCacheSize_(0),
+1 -1
View File
@@ -872,7 +872,7 @@ KernelBlitManager::KernelBlitManager(VirtualGPU& gpu, Setup setup)
: DmaBlitManager(gpu, setup),
program_(nullptr),
xferBufferSize_(0),
lockXferOps_("Transfer Ops Lock", true) {
lockXferOps_(true) /* Transfer Ops Lock*/ {
for (uint i = 0; i < BlitTotal; ++i) {
kernels_[i] = nullptr;
}
+3 -2
View File
@@ -181,7 +181,7 @@ Device::Device(hsa_agent_t bkendDevice)
, xferRead_(nullptr)
, xferWrite_(nullptr)
, freeMem_(0)
, vgpusAccess_("Virtual GPU List Ops Lock", true)
, vgpusAccess_(true) /* Virtual GPU List Ops Lock */
, hsa_exclusive_gpu_access_(false)
, queuePool_(QueuePriority::Total)
, coopHostcallBuffer_(nullptr)
@@ -809,7 +809,8 @@ bool Device::create() {
return false;
}
mapCacheOps_ = new amd::Monitor("Map Cache Lock", true);
// Map Cache Lock
mapCacheOps_ = new amd::Monitor(true);
if (nullptr == mapCacheOps_) {
return false;
}
+1 -1
View File
@@ -98,7 +98,7 @@ public:
ProfilingSignal()
: ts_(nullptr)
, engine_(HwQueueEngine::Compute)
, lock_("Signal Ops Lock", true)
, lock_(true) /* Signal Ops Lock */
, isPacketDispatch_(false)
{
signal_.handle = 0;
+1 -1
View File
@@ -124,7 +124,7 @@ class Timestamp : public amd::ReferenceCountedObject {
, command_(command)
, parsedCommand_(nullptr)
, callback_signal_(hsa_signal_t{})
, lock_("Timestamp lock", true) {}
, lock_(true) /* Timestamp lock */ {}
~Timestamp() {}