From 145944dc3097f7f5e470dac79d218e10ae673a96 Mon Sep 17 00:00:00 2001 From: "Madsen, Jonathan" Date: Mon, 30 Jun 2025 17:02:53 -0500 Subject: [PATCH] [CI] Disable conversion script validation (#492) - pytest fails when you selectively disable all the tests in the suite [ROCm/rocprofiler-sdk commit: 99e262ca4a9aac89de7b1a857eaa4894ba8c022b] --- .../rocprofv3/conversion-script/CMakeLists.txt | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/projects/rocprofiler-sdk/tests/rocprofv3/conversion-script/CMakeLists.txt b/projects/rocprofiler-sdk/tests/rocprofv3/conversion-script/CMakeLists.txt index 9c5b5bee58..85af3356cb 100644 --- a/projects/rocprofiler-sdk/tests/rocprofv3/conversion-script/CMakeLists.txt +++ b/projects/rocprofiler-sdk/tests/rocprofv3/conversion-script/CMakeLists.txt @@ -30,10 +30,6 @@ project( find_package(rocprofiler-sdk REQUIRED) -if(ROCPROFILER_DISABLE_UNSTABLE_CTESTS) - set(PYTEST_ARGS -k "not test_validate_counter_collection_pmc1") -endif() - # copy to binary directory rocprofiler_configure_pytest_files(COPY validate.py input.txt conftest.py CONFIG pytest.ini) @@ -109,6 +105,14 @@ foreach(i RANGE 0 ${convert_test_length}) "${ROCPROFILER_DEFAULT_FAIL_REGEX}") set_tests_properties( ${validate_test_name} - PROPERTIES TIMEOUT 45 LABELS "integration-tests" DEPENDS ${test_name} - FAIL_REGULAR_EXPRESSION "${ROCPROFILER_DEFAULT_FAIL_REGEX}") + PROPERTIES TIMEOUT + 45 + LABELS + "integration-tests" + DEPENDS + ${test_name} + FAIL_REGULAR_EXPRESSION + "${ROCPROFILER_DEFAULT_FAIL_REGEX}" + DISABLED + "${ROCPROFILER_DISABLE_UNSTABLE_CTESTS}") endforeach()