AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-465162 - Fix some issue with image support

Browse Source 
Fix some small issues regarding image and mipmap support

Change-Id: I8e64223d44f37c2dbb115cbb343441a48021ba7b
This commit is contained in:
taosang2
2024-06-10 17:11:08 -04:00
committed by Tao Sang
parent 544c45364f
commit 1566ff7639
3 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hipamd/src/hip_texture.cpp
+16 -3
View File
@@ -110,9 +110,22 @@ hipError_t ihipCreateTextureObject(hipTextureObject_t* pTexObject,
// If hipResourceDesc::resType is set to hipResourceTypeMipmappedArray,
// hipResourceDesc::res::mipmap::mipmap must be set to a valid HIP mipmapped array handle
// and hipTextureDesc::normalizedCoords must be set to true.
if ((pResDesc->resType == hipResourceTypeMipmappedArray) &&
((pResDesc->res.mipmap.mipmap == nullptr) || (pTexDesc->normalizedCoords == 0))) {
return hipErrorInvalidValue;
if (pResDesc->resType == hipResourceTypeMipmappedArray) {
bool mipMapSupport = true;
amd::Context& context = *hip::getCurrentDevice()->asContext();
const std::vector<amd::Device*>& devices = context.devices();
for (auto& dev : devices) {
if (!dev->settings().checkExtension(ClKhrMipMapImage)) {
mipMapSupport = false; // Now PAL-backend can support mipmap, Rocm-backend cannot.
}
}
if (mipMapSupport == false) {
LogInfo("Mipmap not supported on the device");
return hipErrorNotSupported;
}
if (pResDesc->res.mipmap.mipmap == nullptr || pTexDesc->normalizedCoords == 0) {
return hipErrorInvalidValue;
}
}
// If hipResourceDesc::resType is set to hipResourceTypeLinear,