From 16ce520533ca68899b4dfe32d2cdedcc4bb636c2 Mon Sep 17 00:00:00 2001 From: Charis Poag Date: Fri, 23 Aug 2024 11:33:31 -0500 Subject: [PATCH] Fix rocm-smi --showfw displaying error fw prints Updates: - [CLI] Previously --showfw displayed fw that does not exist on systems. This change removes that extra output. Change-Id: If8b063001b80b03579ea1378dfd890c60f62ccd7 Signed-off-by: Charis Poag [ROCm/rocm_smi_lib commit: 6b8db745787cbbe713b2ce763379bffc13e6a6dd] --- projects/rocm-smi-lib/python_smi_tools/rocm_smi.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/rocm-smi-lib/python_smi_tools/rocm_smi.py b/projects/rocm-smi-lib/python_smi_tools/rocm_smi.py index 65d2677b8d..f993713fda 100755 --- a/projects/rocm-smi-lib/python_smi_tools/rocm_smi.py +++ b/projects/rocm-smi-lib/python_smi_tools/rocm_smi.py @@ -2328,7 +2328,7 @@ def showFwInfo(deviceList, fwType): for fw_name in firmware_blocks: fw_name = fw_name.upper() ret = rocmsmi.rsmi_dev_firmware_version_get(device, fw_block_names_l.index(fw_name), byref(fw_ver)) - if rsmi_ret_ok(ret, device, 'get_firmware_version_' + str(fw_name)): + if rsmi_ret_ok(ret, device, 'get_firmware_version_' + str(fw_name), silent=True): # The VCN, VCE, UVD, SOS and ASD firmware's value needs to be in hexadecimal if fw_name in ['VCN', 'VCE', 'UVD', 'SOS', 'ASD', 'MES', 'MES KIQ']: printLog(device, '%s firmware version' % (fw_name),