fix omnitrace print-* with libraries (#94)

* fix omnitrace print-* with libraries

* timemory submodule update

* Update workflows to use ./bin/omnitrace instead of ./omnitrace

* cmake format

* update timemory submodule

- fix ODR violations in utility/procfs

* cmake updates

- uniform find_package for all ROCm-based libraries

* tweak transpose example

- throw exception instead of std::exit

* Inspect cmdv name before assuming not exe

- some ELF execs "think" they are libraries so only assume rewrite + simulate + all-functions if filename looks like library
- adds some test for --print-available -- <library>

* Fix _has_lib_prefix when command is < 3

* Updates and reverts to omnitrace exe

- update module_function operator< and operator==
- add function_signature operator<
- refactor module_function ctor
- revert some previous changes w.r.t. simulate and include_unninstr

* Fix source/bin/tests to use same output dir as tests

* cmake format

* Segfault mitigation + refactor + modify function iteration

- refactor module_function ctor to avoid segfaults
- string_t -> std::string
- replace std::string with std::string_view in some places
- get_name(module_t*)
- get_name(procedure_t*)
- disable using both app_modules and app_functions
- new option: --parse-all-modules to iterate over app_modules
- removed some unused code w.r.t. debug info

* Disable module_function address range for uninstrumentable functions

* Disable module_function address range for uninstrumentable functions

* Refactored getting file/line info and init/fini

- use dyninst insertInitCallback and insertFiniCallback if main not found
- fixed all issues with segmentation faults in --simulate --all-functions

* revert changes to Findrocprofiler.cmake

[ROCm/rocprofiler-systems commit: d04cbe862e]

projects/rocprofiler-systems/source/bin/omnitrace/module_function.cpp

@@ -55,44 +55,48 @@ module_function::module_function(module_t* mod, procedure_t* proc)
 : module{ mod }
 , function{ proc }
 , flow_graph{ proc->getCFG() }
+, module_name{ get_name(module) }
+, function_name{ get_name(function) }
 {
-    if(flow_graph)
-    {
-        flow_graph->getAllBasicBlocks(basic_blocks);
-        flow_graph->getOuterLoops(loop_blocks);
-    }
-
-    instructions.reserve(basic_blocks.size());
-    for(const auto& itr : basic_blocks)
-    {
-        std::vector<instruction_t> _instructions{};
-        itr->getInstructions(_instructions);
-        num_instructions += _instructions.size();
-        if(debug_print || verbose_level > 3 || instr_print)
-            instructions.emplace_back(std::move(_instructions));
-    }
-
-    char modname[FUNCNAMELEN];
-    char fname[FUNCNAMELEN];
-    module->getFullName(modname, FUNCNAMELEN);
-    function->getName(fname, FUNCNAMELEN);
-    module_name   = modname;
-    function_name = fname;
-    signature     = get_func_file_line_info(module, function);
-
     if(!function->isInstrumentable())
     {
-        verbprintf(0,
+        verbprintf(1,
                    "Warning! module function generated for un-instrumentable "
                    "function: %s [%s]\n",
                    function_name.c_str(), module_name.c_str());
     }
-    std::pair<address_t, address_t> _range{};
+
+    auto _range = std::pair<address_t, address_t>{};
     if(function->getAddressRange(_range.first, _range.second))
     {
         start_address = _range.first;
         address_range = _range.second - _range.first;
     }
+
+    signature = get_func_file_line_info(module, function);
+
+    if(function->isInstrumentable())
+    {
+        // this information is potentially not available and
+        // appears to be the cause of a segfault in testing
+        // so only attempt to extract it for instrumentable
+        // functions
+        if(flow_graph)
+        {
+            flow_graph->getAllBasicBlocks(basic_blocks);
+            flow_graph->getOuterLoops(loop_blocks);
+        }
+
+        instructions.reserve(basic_blocks.size());
+        for(const auto& itr : basic_blocks)
+        {
+            std::vector<instruction_t> _instructions{};
+            itr->getInstructions(_instructions);
+            num_instructions += _instructions.size();
+            if(debug_print || verbose_level > 3 || instr_print)
+                instructions.emplace_back(std::move(_instructions));
+        }
+    }
 }
 
 void