From 19007f701534719c2ac6e1c7169f0ed6c9de47ea Mon Sep 17 00:00:00 2001 From: "Xie, Pengda" Date: Tue, 1 Jul 2025 12:59:54 -0700 Subject: [PATCH] SWDEV-536925 - Check for C++ compiler instead of C when building hip (#490) Change cmake to use CMAKE_CXX_COMPILER_ID since CMAKE_COMPILER_IS_GNUCC is deprecated [ROCm/clr commit: 21f6842fff807fdb624e3308d5e58242500a3828] --- projects/clr/hipamd/src/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/clr/hipamd/src/CMakeLists.txt b/projects/clr/hipamd/src/CMakeLists.txt index 8c25a0abea..46ca17212f 100644 --- a/projects/clr/hipamd/src/CMakeLists.txt +++ b/projects/clr/hipamd/src/CMakeLists.txt @@ -27,7 +27,7 @@ if(ADDRESS_SANITIZER) set(ASAN_LINKER_FLAGS "-fsanitize=address") set(ASAN_COMPILER_FLAGS "-fno-omit-frame-pointer -fsanitize=address") - if(NOT CMAKE_COMPILER_IS_GNUCC) + if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU") if(BUILD_SHARED_LIBS) set(ASAN_COMPILER_FLAGS "${ASAN_COMPILER_FLAGS} -shared-libsan") set(ASAN_LINKER_FLAGS "${ASAN_LINKER_FLAGS} -shared-libsan") @@ -42,7 +42,7 @@ if(ADDRESS_SANITIZER) set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${ASAN_LINKER_FLAGS} -Wl,--build-id=sha1") endif() -if(CMAKE_COMPILER_IS_GNUCC) +if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-error=deprecated-declarations") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")