SWDEV-561273 - hip samples on TheRock build using HIP LANGUAGE and hip-lang package. (#1794)

2026-01-29 13:45:58 +05:30
parent fa6f071751
commit 190d9a8e27
30 changed files with 740 additions and 430 deletions
@@ -1,6 +1,24 @@
-project(asm_to_exe)
+# Copyright (c) 2025 Advanced Micro Devices, Inc. All Rights Reserved.
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.

-cmake_minimum_required(VERSION 3.10)
+cmake_minimum_required(VERSION 3.21)

 if(UNIX)
  if(NOT DEFINED ROCM_PATH)
@@ -11,24 +29,25 @@ if(UNIX)
    endif()
  endif()
  if(NOT DEFINED HIP_PATH)
-  if(NOT DEFINED ENV{HIP_PATH})
+    if(NOT DEFINED ENV{HIP_PATH})
      set(HIP_PATH ${ROCM_PATH} CACHE PATH "Path to which HIP has been installed")
-  else()
+    else()
      set(HIP_PATH $ENV{HIP_PATH} CACHE PATH "Path to which HIP has been installed")
-  endif()
+    endif()
  endif()
  list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
 endif()

+project(asm_to_exe LANGUAGES CXX HIP)

-# Find hip
+# Find hip (for HIP_PLATFORM check)
 find_package(hip REQUIRED)

-# Set compiler and linker
-set(HIPCC ${HIP_HIPCC_EXECUTABLE})
-set(CLANG   ${HIP_PATH}/llvm/bin/clang)
-set(LLVM_MC   ${HIP_PATH}/llvm/bin/llvm-mc)
-set(CLANG_OFFLOAD_BUNDLER   ${HIP_PATH}/llvm/bin/clang-offload-bundler)
+# Set compiler and toolchain paths - using amdclang++ directly
+set(HIP_CLANG ${CMAKE_HIP_COMPILER})
+set(CLANG ${HIP_PATH}/llvm/bin/clang)
+set(LLVM_MC ${HIP_PATH}/llvm/bin/llvm-mc)
+set(CLANG_OFFLOAD_BUNDLER ${HIP_PATH}/llvm/bin/clang-offload-bundler)

 set(INCLUDES ${CMAKE_CURRENT_SOURCE_DIR}/../../common)

@@ -36,56 +55,57 @@ set(SRCS ${CMAKE_CURRENT_SOURCE_DIR}/square.cpp)
 set(SQ_HOST_ASM ${CMAKE_CURRENT_BINARY_DIR}/square_host.s)
 set(SQ_HOST_OBJ ${CMAKE_CURRENT_BINARY_DIR}/square_host.o)
 set(SQ_DEVICE_HIPFB ${CMAKE_CURRENT_BINARY_DIR}/offload_bundle.hipfb)
-set(SQ_DEVICE_OBJ   ${CMAKE_CURRENT_BINARY_DIR}/square_device.o)
+set(SQ_DEVICE_OBJ ${CMAKE_CURRENT_BINARY_DIR}/square_device.o)
 set(SQ_ASM_EXE ${CMAKE_CURRENT_BINARY_DIR}/square_asm.out)

 set(MCIN_OBJ_GEN ${CMAKE_CURRENT_SOURCE_DIR}/hip_obj_gen.mcin)

-# Append Current device arch from rocm_agent_enumerator
-# if rocm_agent_enumerator is not found, support --offload-arch
-# to pass arch use format like -DOFFLOAD_ARCH_STR="--offload-arch=gfx1032  --offload-arch=gfx1031"
+# Append Current device arch from amdgpu-arch
+# if amdgpu-arch is not found, support --offload-arch
+# to pass arch use format like -DOFFLOAD_ARCH_STR="--offload-arch=gfx1032 --offload-arch=gfx1031"
 if(UNIX)
-set(ARCH_PATH "${ROCM_PATH}/llvm/bin/amdgpu-arch")
+  set(ARCH_PATH "${ROCM_PATH}/llvm/bin/amdgpu-arch")
 else()
-set(ARCH_PATH "${ROCM_PATH}/bin/amdgpu-arch")
+  set(ARCH_PATH "${ROCM_PATH}/bin/amdgpu-arch")
 endif()

 if(NOT DEFINED OFFLOAD_ARCH_STR
   AND EXISTS "${ARCH_PATH}"
   AND HIP_PLATFORM STREQUAL "amd")
-    execute_process(COMMAND "${ARCH_PATH}"
-         OUTPUT_VARIABLE HIP_GPU_ARCH
-         RESULT_VARIABLE ROCM_AGENT_ENUM_RESULT
-         OUTPUT_STRIP_TRAILING_WHITESPACE)
-    if (NOT HIP_GPU_ARCH STREQUAL "")
-          string(REGEX REPLACE "\n" ";" HIP_GPU_ARCH_LIST "${HIP_GPU_ARCH}")
-          list(REMOVE_DUPLICATES  HIP_GPU_ARCH_LIST)
-          foreach(_hip_gpu_arch ${HIP_GPU_ARCH_LIST})
-              list(APPEND GPU_ARCH ${_hip_gpu_arch})
-          endforeach()
-    else()
-          message(STATUS "ROCm Agent Enumerator found no valid architectures")
-    endif()
-elseif(DEFINED OFFLOAD_ARCH_STR)
-    string(REPLACE "--offload-arch=" ""  HIP_GPU_ARCH_LIST ${OFFLOAD_ARCH_STR})
-    string(REGEX REPLACE " " ";" HIP_GPU_ARCH_LIST "${HIP_GPU_ARCH_LIST}")
+  execute_process(COMMAND "${ARCH_PATH}"
+    OUTPUT_VARIABLE HIP_GPU_ARCH
+    RESULT_VARIABLE ROCM_AGENT_ENUM_RESULT
+    OUTPUT_STRIP_TRAILING_WHITESPACE)
+  if(NOT HIP_GPU_ARCH STREQUAL "")
+    string(REGEX REPLACE "\n" ";" HIP_GPU_ARCH_LIST "${HIP_GPU_ARCH}")
+    list(REMOVE_DUPLICATES HIP_GPU_ARCH_LIST)
    foreach(_hip_gpu_arch ${HIP_GPU_ARCH_LIST})
-          list(APPEND GPU_ARCH ${_hip_gpu_arch})
+      list(APPEND GPU_ARCH ${_hip_gpu_arch})
    endforeach()
+  else()
+    message(STATUS "amdgpu-arch found no valid architectures")
+  endif()
+elseif(DEFINED OFFLOAD_ARCH_STR)
+  string(REPLACE "--offload-arch=" "" HIP_GPU_ARCH_LIST ${OFFLOAD_ARCH_STR})
+  string(REGEX REPLACE " " ";" HIP_GPU_ARCH_LIST "${HIP_GPU_ARCH_LIST}")
+  foreach(_hip_gpu_arch ${HIP_GPU_ARCH_LIST})
+    list(APPEND GPU_ARCH ${_hip_gpu_arch})
+  endforeach()
 endif()

 if(TARGET build_cookbook)
-set(ALL_OPTION )
+  set(ALL_OPTION)
 else()
-set(ALL_OPTION ALL )
+  set(ALL_OPTION ALL)
 endif()

 list(JOIN GPU_ARCH "," OFFLOAD_ARCH)
-add_custom_target(src_to_asm ${ALL_OPTION}  COMMAND ${HIPCC} -c -S -I${INCLUDES} --cuda-host-only -fuse-cuid=none -target x86_64-linux-gnu -o ${SQ_HOST_ASM} ${SRCS}
-                               COMMAND ${HIPCC} -c -S -I${INCLUDES} --cuda-device-only --offload-arch=${OFFLOAD_ARCH} ${SRCS})
+add_custom_target(src_to_asm ${ALL_OPTION}
+  COMMAND ${HIP_CLANG} -x hip -c -S -I${INCLUDES} --cuda-host-only -fuse-cuid=none -target x86_64-linux-gnu -o ${SQ_HOST_ASM} ${SRCS}
+  COMMAND ${HIP_CLANG} -x hip -c -S -I${INCLUDES} --cuda-device-only --offload-arch=${OFFLOAD_ARCH} ${SRCS}
+)

-
-add_custom_command(OUTPUT host_obj COMMAND ${HIPCC} -c ${SQ_HOST_ASM} -o ${SQ_HOST_OBJ})
+add_custom_command(OUTPUT host_obj COMMAND ${HIP_CLANG} -c ${SQ_HOST_ASM} -o ${SQ_HOST_OBJ})

 foreach(ARCH ${GPU_ARCH})
  list(APPEND TARGETS hip-amdgcn-amd-amdhsa--${ARCH})
@@ -98,10 +118,11 @@ endforeach()
 list(JOIN TARGETS "," TARGET_STR)
 list(TRANSFORM INPUTS PREPEND "-input=")
 add_custom_target(asm_to_exec ${ALL_OPTION} DEPENDS src_to_asm host_obj ${arch_obj_targets}
-                               COMMAND ${CLANG_OFFLOAD_BUNDLER} -type=o -bundle-align=4096 -targets=host-x86_64-unknown--linux,${TARGET_STR} -input=/dev/null ${INPUTS} -output=${SQ_DEVICE_HIPFB}
-                               COMMAND ${LLVM_MC} ${MCIN_OBJ_GEN} -o ${SQ_DEVICE_OBJ} --filetype=obj
-                               COMMAND ${HIPCC} ${SQ_HOST_OBJ} ${SQ_DEVICE_OBJ} -o ${SQ_ASM_EXE})
+  COMMAND ${CLANG_OFFLOAD_BUNDLER} -type=o -bundle-align=4096 -targets=host-x86_64-unknown--linux,${TARGET_STR} -input=/dev/null ${INPUTS} -output=${SQ_DEVICE_HIPFB}
+  COMMAND ${LLVM_MC} ${MCIN_OBJ_GEN} -o ${SQ_DEVICE_OBJ} --filetype=obj
+  COMMAND ${HIP_CLANG} ${SQ_HOST_OBJ} ${SQ_DEVICE_OBJ} -o ${SQ_ASM_EXE} -L${ROCM_PATH}/lib -lamdhip64 -Wl,-rpath,${ROCM_PATH}/lib
+)

 if(TARGET build_cookbook)
-add_dependencies(build_cookbook src_to_asm asm_to_exec)
+  add_dependencies(build_cookbook src_to_asm asm_to_exec)
 endif()