From 1b5f5b05bc6835832c298a9895458f2ba93047e2 Mon Sep 17 00:00:00 2001 From: Sebastian Luzynski Date: Tue, 4 Jun 2024 13:22:38 +0000 Subject: [PATCH] SWDEV-465141 - Fix Unit_RTC_LinkAddFile_Negative test failure This test was failing due to the incorrect return vaulue assumption. Signed-off-by: Sebastian Luzynski Change-Id: I88a18665a3be221157134f0855a814dba013e293 --- catch/hipTestMain/config/config_amd_linux | 2 -- catch/hipTestMain/config/config_amd_windows | 2 -- catch/unit/rtc/linker.cc | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/catch/hipTestMain/config/config_amd_linux b/catch/hipTestMain/config/config_amd_linux index 727f3e65c0..8ec062709f 100644 --- a/catch/hipTestMain/config/config_amd_linux +++ b/catch/hipTestMain/config/config_amd_linux @@ -774,8 +774,6 @@ "Unit_Device_remquo_Accuracy_Positive - double", "Unit_Device_modf_Accuracy_Positive - float", "Unit_Device_modf_Accuracy_Positive - double", - "=== SWDEV-450255 & SWDEV-449527 ===", - "Unit_RTC_LinkAddFile_Negative", "=== Below tests cause timeout in stress test of 09/02/24 ===", "Unit_Device___half2half2_Accuracy_Positive", "Unit_Device_make_half2_Accuracy_Positive", diff --git a/catch/hipTestMain/config/config_amd_windows b/catch/hipTestMain/config/config_amd_windows index bea27e2bbb..1b6e413953 100644 --- a/catch/hipTestMain/config/config_amd_windows +++ b/catch/hipTestMain/config/config_amd_windows @@ -1426,8 +1426,6 @@ "Unit_atomicCAS_system_Positive_Host_And_Peer_GPUs - int", "Unit_atomicCAS_system_Positive_Host_And_Peer_GPUs - unsigned int", "Unit_atomicCAS_system_Positive_Host_And_Peer_GPUs - unsigned long long", - "=== SWDEV-450255 & SWDEV-449527 ===", - "Unit_RTC_LinkAddFile_Negative", "=== SWDEV-453453 : Below tests failed in stress test on 22/03/24 ===", "Unit_hipDeviceGetGraphMemAttribute_Functional", "Unit_hipDeviceGetGraphMemAttribute_Functional_Multi_Device", diff --git a/catch/unit/rtc/linker.cc b/catch/unit/rtc/linker.cc index 3ecc376500..f4c3299502 100644 --- a/catch/unit/rtc/linker.cc +++ b/catch/unit/rtc/linker.cc @@ -145,7 +145,7 @@ TEST_CASE("Unit_RTC_LinkAddFile_Negative") { SECTION("link add file - incorrect hiprtcLinkState") { hiprtcLinkState linkstate; REQUIRE(hiprtcLinkAddFile(linkstate, input_type, file_name, 0, nullptr, nullptr) == - HIPRTC_ERROR_PROGRAM_CREATION_FAILURE); + HIPRTC_ERROR_INVALID_INPUT); } SECTION("link add file - nullptr hiprtcLinkState") {