AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable ATT continuous mode and code object tracing registration (#850)

Browse Source 
* Adding ATT continuous mode and ATT code object tracking

* Fixing aql_packet.cpp

* Updating to aqlprofile codeobj changes

* Removing kernel packet from ATT dispatch callback

* Changing getSymbolMap() to return relative vaddr

* Tidy fixes

* Formatting

* Fix shadowing

* Fixing packet test

* Updating tests

* Simplifying multi-agent traces

* Adding dynamic codeobj tracking

* leftover book-keeping for codeobj markers

* Formatting

* Formatting

* Temporary removing codeobj marker

* Formatting

* Re-enabling codeobj tracking

* Making copy of coreapi table

* Fixing issues with toolData lifetile

* Formatting

* Fixing issues with ASAN

* Improving memory profile

* Removing misplaced annotation

* Fixing queue type and allowing shared_locks in globalThreadTracer

* Update logging

* Changing ATT formats to be more in line with the SDk (#883)

* Fixing some merge conflicts

* Fixing cmakelists

* Fixing merge conflicts

* Formatting
This commit is contained in:
Giovanni Lenzi Baraldi
2024-05-29 13:09:28 -03:00
committed by GitHub
parent 2225153c23
commit 1b95089c28
24 changed files with 1696 additions and 824 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/lib/rocprofiler-sdk/thread_trace/att_service.cpp
+33 -20
View File
@@ -25,6 +25,7 @@
#include "lib/rocprofiler-sdk/aql/helpers.hpp"
#include "lib/rocprofiler-sdk/context/context.hpp"
#include "lib/rocprofiler-sdk/hsa/agent_cache.hpp"
#include "lib/rocprofiler-sdk/registration.hpp"
extern "C" {
rocprofiler_status_t ROCPROFILER_API
@@ -35,16 +36,20 @@ rocprofiler_configure_thread_trace_service(rocprofiler_context_id_t
rocprofiler_att_shader_data_callback_t shader_callback,
void* callback_userdata)
{
if(rocprofiler::registration::get_init_status() > -1)
return ROCPROFILER_STATUS_ERROR_CONFIGURATION_LOCKED;
auto* ctx = rocprofiler::context::get_mutable_registered_context(context_id);
if(!ctx) return ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_STARTED;
if(ctx->thread_trace) return ROCPROFILER_STATUS_ERROR_SERVICE_ALREADY_CONFIGURED;
auto thread_tracer = std::make_shared<rocprofiler::thread_trace_parameter_pack>();
auto param_pack = rocprofiler::thread_trace_parameter_pack{};
thread_tracer->context_id = context_id;
thread_tracer->dispatch_cb_fn = dispatch_callback;
thread_tracer->shader_cb_fn = shader_callback;
thread_tracer->callback_userdata = callback_userdata;
param_pack.context_id = context_id;
param_pack.dispatch_cb_fn = dispatch_callback;
param_pack.shader_cb_fn = shader_callback;
param_pack.callback_userdata = callback_userdata;
bool bEnableCodeobj = false;
for(size_t p = 0; p < num_parameters; p++)
{
@@ -54,30 +59,38 @@ rocprofiler_configure_thread_trace_service(rocprofiler_context_id_t
switch(param.type)
{
case ROCPROFILER_ATT_PARAMETER_TARGET_CU: thread_tracer->target_cu = param.value; break;
case ROCPROFILER_ATT_PARAMETER_TARGET_CU: param_pack.target_cu = param.value; break;
case ROCPROFILER_ATT_PARAMETER_SHADER_ENGINE_MASK:
thread_tracer->shader_engine_mask = param.value;
param_pack.shader_engine_mask = param.value;
break;
case ROCPROFILER_ATT_PARAMETER_BUFFER_SIZE:
thread_tracer->buffer_size = param.value;
case ROCPROFILER_ATT_PARAMETER_BUFFER_SIZE: param_pack.buffer_size = param.value; break;
case ROCPROFILER_ATT_PARAMETER_SIMD_SELECT: param_pack.simd_select = param.value; break;
case ROCPROFILER_ATT_PARAMETER_CODE_OBJECT_TRACE_ENABLE:
bEnableCodeobj = param.value != 0;
break;
case ROCPROFILER_ATT_PARAMETER_SIMD_SELECT:
thread_tracer->simd_select = param.value;
break;
case ROCPROFILER_ATT_PARAMETER_OCCUPANCY_MODE_ENABLE:
return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED;
case ROCPROFILER_ATT_PARAMETER_PERFCOUNTERS_CTRL:
return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED;
case ROCPROFILER_ATT_PARAMETER_PERFCOUNTER:
return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED;
case ROCPROFILER_ATT_PARAMETER_LAST: return ROCPROFILER_STATUS_ERROR_INVALID_ARGUMENT;
}
// for(int i = 0; i < parameters.perfcounter_num; i++)
// thread_tracer->perfcounters.emplace_back(parameters.perfcounter[i]);
}
ctx->thread_trace = std::make_shared<rocprofiler::ThreadTracer>(thread_tracer);
ctx->thread_trace = std::make_shared<rocprofiler::GlobalThreadTracer>(param_pack);
return ROCPROFILER_STATUS_SUCCESS;
if(!bEnableCodeobj) return ROCPROFILER_STATUS_SUCCESS; // Skip TRACING_CODE_OBJECT setup
auto& client_ctx = ctx->thread_trace->codeobj_client_ctx;
rocprofiler_status_t status = rocprofiler_create_context(&client_ctx);
if(status != ROCPROFILER_STATUS_SUCCESS) return status;
status = rocprofiler_configure_callback_tracing_service(
client_ctx,
ROCPROFILER_CALLBACK_TRACING_CODE_OBJECT,
nullptr,
0,
rocprofiler::GlobalThreadTracer::codeobj_tracing_callback,
ctx->thread_trace.get());
return status;
}
}