From 1dca3b328fae080ebdd18d432a199358c3a7ee9c Mon Sep 17 00:00:00 2001 From: ROCm CI Service Account <66695075+rocm-ci@users.noreply.github.com> Date: Thu, 24 Feb 2022 20:43:14 +0530 Subject: [PATCH] SWDEV-306122 - [catch2][dtest] Tests for hipGraphAddMemcpyNodeFromSymbol API (#2506) Added Negative and functional tests for hipGraphAddMemcpyNodeFromSymbol API Change-Id: Ic65045ca56ae8949efd7690e62f788ff888cd893 --- tests/catch/unit/graph/CMakeLists.txt | 1 + .../graph/hipGraphAddMemcpyNodeFromSymbol.cc | 435 ++++++++++++++++++ 2 files changed, 436 insertions(+) create mode 100644 tests/catch/unit/graph/hipGraphAddMemcpyNodeFromSymbol.cc diff --git a/tests/catch/unit/graph/CMakeLists.txt b/tests/catch/unit/graph/CMakeLists.txt index 1143ddda4e..1e57939a81 100644 --- a/tests/catch/unit/graph/CMakeLists.txt +++ b/tests/catch/unit/graph/CMakeLists.txt @@ -28,6 +28,7 @@ set(TEST_SRC hipGraphClone.cc hipGraphInstantiateWithFlags.cc hipGraphAddHostNode.cc + hipGraphAddMemcpyNodeFromSymbol.cc ) hip_add_exe_to_target(NAME GraphsTest diff --git a/tests/catch/unit/graph/hipGraphAddMemcpyNodeFromSymbol.cc b/tests/catch/unit/graph/hipGraphAddMemcpyNodeFromSymbol.cc new file mode 100644 index 0000000000..7d9cbaffed --- /dev/null +++ b/tests/catch/unit/graph/hipGraphAddMemcpyNodeFromSymbol.cc @@ -0,0 +1,435 @@ +/* +Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved. +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: +The above copyright notice and this permission notice shall be included in +all copies or substantial portions of the Software. +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANNTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER INN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR INN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +THE SOFTWARE. +*/ + +/** +Testcase Scenarios of hipGraphAddMemcpyNodeFromSymbol API: + +Functional : + +1. Allocate global symbol memory, add the MemcpyNodeFromSymbol + node to the graph and verify for different memory kinds +2. Allocate const memory add the MemcpyNodeFromSymbol node to + the graph and verify for different memory kinds +3. Allocate global symbol memory and device memory in GPU-0 + and perform MemcpyToSymbol from peer GPU by adding it to the graph node. +4. Allocate const symbol memory and device memory in GPU-0 + and perform MemcpyToSymbol from peer GPU by adding it to the graph node. +5. Allocate global memory, Add MemcpyFromSymbolNode,KernelNode and memcpynode and validating + the behaviour + +Negative : + +1) Pass nullptr to graph node +2) Pass nullptr to graph +3) Pass nullptr to dependencies +4) Pass invalid numDependencies +5) Pass nullptr to dst +6) Pass nullptr to symbol +7) Pass invalid count +8) Pass offset+count greater than allocated size +9) Pass unintialized graph +*/ + +#include +#include +#include +#define SIZE 256 + +__device__ int globalIn[SIZE]; +__device__ int globalOut[SIZE]; +__device__ __constant__ int globalConst[SIZE]; + +__global__ void MemcpyFromSymbolKernel(int* B_d) { + for (int i = 0 ; i < SIZE; i++) { + globalIn[i] = B_d[i]; + } +} + +/* This testcase verifies negative scenarios of + hipGraphAddMemcpyNodeFromSymbol API */ +TEST_CASE("Unit_hipGraphAddMemcpyNodeFromSymbol_Negative") { + constexpr size_t Nbytes = SIZE * sizeof(int); + int *A_d{nullptr}, *B_d{nullptr}; + int *A_h{nullptr}, *B_h{nullptr}; + HipTest::initArrays(&A_d, &B_d, nullptr, + &A_h, &B_h, nullptr, SIZE, false); + + hipGraph_t graph; + hipGraphNode_t memcpyToSymbolNode, memcpyH2D_A; + std::vector dependencies; + HIP_CHECK(hipGraphCreate(&graph, 0)); + + // Adding MemcpyNode + HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, + Nbytes, hipMemcpyHostToDevice)); + dependencies.push_back(memcpyH2D_A); + + // Adding MemcpyNodeToSymbol + HIP_CHECK(hipGraphAddMemcpyNodeToSymbol(&memcpyToSymbolNode, graph, + dependencies.data(), + dependencies.size(), + HIP_SYMBOL(globalIn), + A_d, Nbytes, 0, + hipMemcpyDeviceToDevice)); + dependencies.clear(); + dependencies.push_back(memcpyToSymbolNode); + +#if HT_NVIDIA + hipGraphNode_t memcpyFromSymbolNode; + SECTION("Passing nullptr to graph") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, nullptr, + dependencies.data(), + dependencies.size(), + B_d, + HIP_SYMBOL(globalIn), + Nbytes, 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } + + SECTION("Passing nullptr to graph node") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(nullptr, graph, + dependencies.data(), + dependencies.size(), + B_d, + HIP_SYMBOL(globalIn), + Nbytes, 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } + + SECTION("Passing size > 1 and dependencies as nullptr") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + nullptr, + 1, + B_d, + HIP_SYMBOL(globalIn), + Nbytes, 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } + + SECTION("Passing invalid dependencies size") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + 10, + B_d, + HIP_SYMBOL(globalIn), + Nbytes, 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } + + SECTION("Passing nullptr to dst") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + dependencies.size(), + nullptr, + HIP_SYMBOL(globalIn), Nbytes, 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } + + SECTION("Passing nullptr to source") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + dependencies.size(), + B_d, + nullptr, Nbytes, 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidSymbol); + } + + SECTION("Passing offset+size > max size") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + dependencies.size(), + B_d, + HIP_SYMBOL(globalIn), + Nbytes, 10, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } + + SECTION("Passing Max count") { + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + dependencies.size(), + B_d, + HIP_SYMBOL(globalIn), + std::numeric_limits::max(), 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } + + SECTION("Pass Unintialized graph") { + hipGraph_t unint_graph; + REQUIRE(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, unint_graph, + dependencies.data(), + dependencies.size(), + B_d, + HIP_SYMBOL(globalIn), + Nbytes, 0, + hipMemcpyDeviceToDevice) + == hipErrorInvalidValue); + } +#endif + + HipTest::freeArrays(A_d, B_d, nullptr, + A_h, B_h, nullptr, false); + HIP_CHECK(hipGraphDestroy(graph)); +} +/* +This function is used to verify the following scenarios +1. Create global variable, allocate Memory in GPU-0 and create dependency graph of + hipGraphAddMemcpyNodeFromSymbol API in GPU-1 and validate the result +2. Allocate global memory, Create dependency graph and validate the result on GPU-0 +3. Allocate global const memory, Create dependency graph and validate the result on GPU-0 +4. Create global const variable, allocate Memory in GPU-0 and create dependency graph of + hipGraphAddMemcpyNodeFromSymbol API in GPU-1 and validate the result +*/ + +void hipGraphAddMemcpyNodeFromSymbol_GlobalMemory(bool device_ctxchg = false, + bool const_device_var = + false) { + constexpr size_t Nbytes = SIZE * sizeof(int); + int *A_d{nullptr}; + int *A_h{nullptr}, *B_h{nullptr}; + HipTest::initArrays(&A_d, nullptr, nullptr, + &A_h, &B_h, nullptr, SIZE, false); + + hipGraph_t graph; + hipGraphExec_t graphExec; + hipGraphNode_t memcpyToSymbolNode, memcpyFromSymbolNode, memcpyH2D_A; + std::vector dependencies; + HIP_CHECK(hipGraphCreate(&graph, 0)); + + if (device_ctxchg) { + HIP_CHECK(hipSetDevice(1)); + HIP_CHECK(hipDeviceEnablePeerAccess(0, 0)); + } + // Adding MemcpyNode + HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, + Nbytes, hipMemcpyHostToDevice)); + dependencies.push_back(memcpyH2D_A); + + // Adding MemcpyNodeToSymbol + if (const_device_var) { + HIP_CHECK(hipGraphAddMemcpyNodeToSymbol(&memcpyToSymbolNode, graph, + dependencies.data(), + dependencies.size(), + HIP_SYMBOL(globalConst), + A_d, Nbytes, 0, + hipMemcpyDeviceToDevice)); + + } else { + HIP_CHECK(hipGraphAddMemcpyNodeToSymbol(&memcpyToSymbolNode, graph, + dependencies.data(), + dependencies.size(), + HIP_SYMBOL(globalIn), + A_d, Nbytes, 0, + hipMemcpyDeviceToDevice)); + } + dependencies.clear(); + dependencies.push_back(memcpyToSymbolNode); + + + // Adding MemcpyNodeFromSymbol + if (const_device_var) { + HIP_CHECK(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + dependencies.size(), + B_h, + HIP_SYMBOL(globalConst), + Nbytes, 0, + hipMemcpyDeviceToHost)); + } else { + HIP_CHECK(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + dependencies.size(), + B_h, + HIP_SYMBOL(globalIn), + Nbytes, 0, + hipMemcpyDeviceToHost)); + } + + + // Instantiate and launch the graph + HIP_CHECK(hipGraphInstantiate(&graphExec, graph, nullptr, nullptr, 0)); + HIP_CHECK(hipGraphLaunch(graphExec, 0)); + + // Validating the result + for (int i = 0; i < SIZE; i++) { + if (B_h[i] != A_h[i]) { + WARN("Validation failed B_h[i] " << B_h[i] << "A_h[i] " << A_h[i]); + REQUIRE(false); + } + } + + HipTest::freeArrays(A_d, nullptr, nullptr, + A_h, B_h, nullptr, false); + HIP_CHECK(hipGraphExecDestroy(graphExec)); + HIP_CHECK(hipGraphDestroy(graph)); +} +/* +This testcase verifies allocating global symbol memory, +add the MemcpyNodeFromSymbol node to the graph and +erifying the result +*/ +TEST_CASE("Unit_hipGraphAddMemcpyNodeFromSymbol_GlobalMemory") { + hipGraphAddMemcpyNodeFromSymbol_GlobalMemory(false, false); +} + +/* +This testcase verifies allocating global const symbol memory, +add the MemcpyNodeFromSymbol node to the graph and +verifying the result +*/ + +TEST_CASE("Unit_hipGraphAddMemcpyNodeFromSymbol_GlobalConstMemory") { + hipGraphAddMemcpyNodeFromSymbol_GlobalMemory(false, true); +} + +/* +This testcase verifies allocating global symbol memory and device variables +in GPU-0 and add the MemcpyNodeFromSymbol node to the graph and +verifying the result in GPU-1 +*/ +#if HT_NVIDIA +TEST_CASE("Unit_hipGraphAddMemcpyNodeFromSymbol_GlobalMemoryPeerDevice") { + int numDevices = 0; + int canAccessPeer = 0; + if (numDevices > 1) { + HIP_CHECK(hipDeviceCanAccessPeer(&canAccessPeer, 0, 1)); + if (canAccessPeer) { + hipGraphAddMemcpyNodeFromSymbol_GlobalMemory(true, false); + } else { + SUCCEED("Machine does not seem to have P2P"); + } + } else { + SUCCEED("skipped the testcase as no of devices is less than 2"); + } +} + +/* +This testcase verifies allocating global const symbol memory and device variables +in GPU-0 and add the MemcpyNodeFromSymbol node to the graph and +verifying the result in GPU-1 +*/ + +TEST_CASE("Unit_hipGraphAddMemcpyNodeFromSymbol_GlobalConstMemoryPeerDevice") { + int numDevices = 0; + int canAccessPeer = 0; + if (numDevices > 1) { + HIP_CHECK(hipDeviceCanAccessPeer(&canAccessPeer, 0, 1)); + if (canAccessPeer) { + hipGraphAddMemcpyNodeFromSymbol_GlobalMemory(true, true); + } else { + SUCCEED("Machine does not seem to have P2P"); + } + } else { + SUCCEED("skipped the testcase as no of devices is less than 2"); + } +} +#endif +/* +This testcaser verifies allocating global memory, +Add MemcpyFromSymbolNode,KernelNode and memcpynode and validating +the behaviour +*/ +TEST_CASE("Unit_hipGraphAddMemcpyNodeFromSymbol_GlobalMemoryWithKernel") { + constexpr size_t Nbytes = SIZE * sizeof(int); + constexpr auto blocksPerCU = 6; // to hide latency + constexpr auto threadsPerBlock = 256; + unsigned blocks = HipTest::setNumBlocks(blocksPerCU, threadsPerBlock, SIZE); + hipGraphNode_t memcpyfromsymbolkernel, memcpyD2H_B; + hipKernelNodeParams kernelNodeParams{}; + int *A_d{nullptr}, *B_d{nullptr}; + int *A_h{nullptr}, *B_h{nullptr}; + HipTest::initArrays(&A_d, &B_d, nullptr, + &A_h, &B_h, nullptr, SIZE, false); + + hipGraph_t graph; + hipGraphExec_t graphExec; + hipGraphNode_t memcpyToSymbolNode, memcpyFromSymbolNode, memcpyH2D_A; + std::vector dependencies; + HIP_CHECK(hipGraphCreate(&graph, 0)); + + // Adding MemcpyNode + HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, + Nbytes, hipMemcpyHostToDevice)); + dependencies.push_back(memcpyH2D_A); + + HIP_CHECK(hipGraphAddMemcpyNodeToSymbol(&memcpyToSymbolNode, graph, + dependencies.data(), + dependencies.size(), + HIP_SYMBOL(globalIn), + A_d, Nbytes, 0, + hipMemcpyDeviceToDevice)); + dependencies.clear(); + dependencies.push_back(memcpyToSymbolNode); + + + HIP_CHECK(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, graph, + dependencies.data(), + dependencies.size(), + B_d, + HIP_SYMBOL(globalIn), + Nbytes, 0, + hipMemcpyDeviceToDevice)); + dependencies.clear(); + dependencies.push_back(memcpyFromSymbolNode); + + // Adding Kernel node + void* kernelArgs1[] = {&B_d}; + kernelNodeParams.func = + reinterpret_cast(MemcpyFromSymbolKernel); + kernelNodeParams.gridDim = dim3(blocks); + kernelNodeParams.blockDim = dim3(threadsPerBlock); + kernelNodeParams.sharedMemBytes = 0; + kernelNodeParams.kernelParams = reinterpret_cast(kernelArgs1); + kernelNodeParams.extra = nullptr; + HIP_CHECK(hipGraphAddKernelNode(&memcpyfromsymbolkernel, graph, + dependencies.data(), dependencies.size(), + &kernelNodeParams)); + dependencies.clear(); + dependencies.push_back(memcpyfromsymbolkernel); + + // Adding MemcpyNode + HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyD2H_B, graph, dependencies.data(), + dependencies.size(), B_h, B_d, + Nbytes, hipMemcpyDeviceToHost)); + + // Instantiate and launch the graph + HIP_CHECK(hipGraphInstantiate(&graphExec, graph, nullptr, nullptr, 0)); + HIP_CHECK(hipGraphLaunch(graphExec, 0)); + + // Validating the result + for (int i = 0; i < SIZE; i++) { + if (B_h[i] != A_h[i]) { + WARN("Validation failed B_h[i] " << B_h[i] << "A_h[i] " << A_h[i]); + REQUIRE(false); + } + } + + HipTest::freeArrays(A_d, B_d, nullptr, + A_h, B_h, nullptr, false); + HIP_CHECK(hipGraphExecDestroy(graphExec)); + HIP_CHECK(hipGraphDestroy(graph)); +}