Miscellaneous updates (#959)

- missing-new-line CI job: ensures all source files end with new line
- logging updates
- add new line to the end of many files
- fix header include ordering is misc places
- transition to use hsa::get_core_table() and hsa::get_amd_ext_table() in various places instead of making copies

source/lib/rocprofiler-sdk/aql/helpers.cpp

@@ -21,15 +21,15 @@
 // SOFTWARE.
 
 #include "lib/rocprofiler-sdk/aql/helpers.hpp"
-
-#include <fmt/core.h>
-
-#include <rocprofiler-sdk/fwd.h>
-
 #include "lib/common/logging.hpp"
 #include "lib/common/synchronized.hpp"
 #include "lib/common/utility.hpp"
 #include "lib/rocprofiler-sdk/counters/id_decode.hpp"
+#include "lib/rocprofiler-sdk/hsa/hsa.hpp"
+
+#include <rocprofiler-sdk/fwd.h>
+
+#include <fmt/core.h>
 
 namespace rocprofiler
 {
@@ -114,11 +114,15 @@ get_dim_info(rocprofiler_agent_id_t   agent,
 }
 
 rocprofiler_status_t
-set_profiler_active_on_queue(const AmdExtTable&                api,
-                             hsa_amd_memory_pool_t             pool,
+set_profiler_active_on_queue(hsa_amd_memory_pool_t             pool,
                              hsa_agent_t                       hsa_agent,
                              const rocprofiler_profile_pkt_cb& packet_submit)
 {
+    CHECK(hsa::get_amd_ext_table() != nullptr);
+    CHECK(hsa::get_amd_ext_table()->hsa_amd_memory_pool_allocate_fn != nullptr);
+    CHECK(hsa::get_amd_ext_table()->hsa_amd_agents_allow_access_fn != nullptr);
+    CHECK(hsa::get_amd_ext_table()->hsa_amd_memory_pool_free_fn != nullptr);
+
     // Inject packet to enable profiling of other process queues on this queue
     hsa_ven_amd_aqlprofile_profile_t profile{};
     profile.agent = hsa_agent;
@@ -134,15 +138,15 @@ set_profiler_active_on_queue(const AmdExtTable&                api,
     const size_t mask = 0x1000 - 1;
     auto         size = (profile.command_buffer.size + mask) & ~mask;
 
-    if(api.hsa_amd_memory_pool_allocate_fn(pool, size, 0, &profile.command_buffer.ptr) !=
-       HSA_STATUS_SUCCESS)
+    if(hsa::get_amd_ext_table()->hsa_amd_memory_pool_allocate_fn(
+           pool, size, 0, &profile.command_buffer.ptr) != HSA_STATUS_SUCCESS)
     {
         ROCP_WARNING << "Failed to allocate memory to enable profile command on agent, some "
                         "counters will be unavailable";
         return ROCPROFILER_STATUS_ERROR;
     }
-    if(api.hsa_amd_agents_allow_access_fn(1, &hsa_agent, nullptr, profile.command_buffer.ptr) !=
-       HSA_STATUS_SUCCESS)
+    if(hsa::get_amd_ext_table()->hsa_amd_agents_allow_access_fn(
+           1, &hsa_agent, nullptr, profile.command_buffer.ptr) != HSA_STATUS_SUCCESS)
     {
         ROCP_WARNING << "Agent cannot access memory, some counters will be unavailable";
         return ROCPROFILER_STATUS_ERROR;
@@ -157,7 +161,7 @@ set_profiler_active_on_queue(const AmdExtTable&                api,
     }
 
     packet_submit(packet);
-    api.hsa_amd_memory_pool_free_fn(profile.command_buffer.ptr);
+    hsa::get_amd_ext_table()->hsa_amd_memory_pool_free_fn(profile.command_buffer.ptr);
     return ROCPROFILER_STATUS_SUCCESS;
 }