Miscellaneous updates (#959)

- missing-new-line CI job: ensures all source files end with new line
- logging updates
- add new line to the end of many files
- fix header include ordering is misc places
- transition to use hsa::get_core_table() and hsa::get_amd_ext_table() in various places instead of making copies

source/lib/rocprofiler-sdk/counters/agent_profiling.hpp

@@ -21,13 +21,13 @@
 // SOFTWARE.
 #pragma once
 
+#include "lib/rocprofiler-sdk/counters/controller.hpp"
+#include "lib/rocprofiler-sdk/hsa/aql_packet.hpp"
+
 #include <rocprofiler-sdk/fwd.h>
 #include <rocprofiler-sdk/hsa.h>
 #include <rocprofiler-sdk/rocprofiler.h>
 
-#include "lib/rocprofiler-sdk/counters/controller.hpp"
-#include "lib/rocprofiler-sdk/hsa/aql_packet.hpp"
-
 namespace rocprofiler
 {
 namespace context
@@ -39,41 +39,40 @@ namespace counters
 {
 struct agent_callback_data
 {
-    uint64_t                               context_idx{0};
-    CoreApiTable                           table;
-    hsa_queue_t*                           queue{nullptr};
-    std::unique_ptr<hsa::CounterAQLPacket> packet;
+    uint64_t                               context_idx = 0;
+    hsa_queue_t*                           queue       = nullptr;
+    std::unique_ptr<hsa::CounterAQLPacket> packet      = {};
 
     // Tri-state signal used to know what the current state of processing
     // a sample is. The states are:
     //   1: allow next sample to start (i.e. no in progress work)
     //   0: sample in progress
     //  -1: sample complete  (i.e. signal for caller that sample is ready)
-    hsa_signal_t completion{.handle = 0};
+    hsa_signal_t            completion    = {.handle = 0};
+    hsa_signal_t            start_signal  = {.handle = 0};
+    rocprofiler_user_data_t user_data     = {.value = 0};
+    rocprofiler_user_data_t callback_data = {.value = 0};
 
-    hsa_signal_t            start_signal{.handle = 0};
-    rocprofiler_user_data_t user_data{.value = 0};
-    rocprofiler_user_data_t callback_data{.ptr = nullptr};
-
-    std::shared_ptr<rocprofiler::counters::profile_config> profile;
-    rocprofiler_agent_id_t                                 agent_id{.handle = 0};
-    rocprofiler_agent_profile_callback_t                   cb;
-    rocprofiler_buffer_id_t                                buffer{.handle = 0};
-    bool                                                   set_profile{false};
+    std::shared_ptr<rocprofiler::counters::profile_config> profile     = {};
+    rocprofiler_agent_id_t                                 agent_id    = {.handle = 0};
+    rocprofiler_agent_profile_callback_t                   cb          = nullptr;
+    rocprofiler_buffer_id_t                                buffer      = {.handle = 0};
+    bool                                                   set_profile = false;
 
     agent_callback_data() = default;
-    agent_callback_data(agent_callback_data&& other) noexcept
-    : table(other.table)
-    , queue(other.queue)
-    , packet(std::move(other.packet))
-    , completion(other.completion)
-    , start_signal(other.start_signal)
-    , user_data(other.user_data)
-    , callback_data(other.callback_data)
-    , profile(other.profile)
-    , agent_id(other.agent_id)
-    , cb(other.cb)
-    , buffer(other.buffer){};
+    agent_callback_data(agent_callback_data&& rhs) noexcept
+    : queue(rhs.queue)
+    , packet(std::move(rhs.packet))
+    , completion(rhs.completion)
+    , start_signal(rhs.start_signal)
+    , user_data(rhs.user_data)
+    , callback_data(rhs.callback_data)
+    , profile(rhs.profile)
+    , agent_id(rhs.agent_id)
+    , cb(rhs.cb)
+    , buffer(rhs.buffer)
+    {}
+
     ~agent_callback_data();
 };
 
@@ -108,7 +107,7 @@ read_agent_ctx(const context::context*    ctx,
                rocprofiler_counter_flag_t flags);
 
 uint64_t
-submitPacket(const CoreApiTable& table, hsa_queue_t* queue, const void* packet);
+submitPacket(hsa_queue_t* queue, const void* packet);
 
 }  // namespace counters
-}  // namespace rocprofiler
+}  // namespace rocprofiler