From 1f5303c7c30ce8bb7e469e508337f5a4fe45620e Mon Sep 17 00:00:00 2001 From: Jorghi12 Date: Mon, 23 Jul 2018 18:16:00 -0400 Subject: [PATCH] Fixing a HIP bug that causes DEBUG symbols to be dropped. I've noticed that in the generated makefiles, we'd have if(NOT build_configuration) set(build_configuration Debug) endif() However, only definitions with all capitals are provided. e.g. set(HIP_HCC_FLAGS_DEBUG -g) This is because of lines 442 to 448. We capitalize the configuration ${config_upper}. This PR fixes this bug. [ROCm/clr commit: 25c780c89e9f371ff9ec13e9a826a9586b0d4412] --- projects/clr/hipamd/cmake/FindHIP.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/clr/hipamd/cmake/FindHIP.cmake b/projects/clr/hipamd/cmake/FindHIP.cmake index 9a1a285921..ec2c98b642 100644 --- a/projects/clr/hipamd/cmake/FindHIP.cmake +++ b/projects/clr/hipamd/cmake/FindHIP.cmake @@ -380,7 +380,7 @@ endmacro() ############################################################################### macro(HIP_PREPARE_TARGET_COMMANDS _target _format _generated_files _source_files) set(_hip_flags "") - set(_hip_build_configuration "${CMAKE_BUILD_TYPE}") + string(TOUPPER _hip_build_configuration "${CMAKE_BUILD_TYPE}") if(HIP_HOST_COMPILATION_CPP) set(HIP_C_OR_CXX CXX) else()