Linting workflow and clang-tidy fixes (#72)

* Update source/{bin,lib/{common,rocprofiler}}/CMakeLists.txt

- activate clang-tidy

* Update PTL submodule

- clang-tidy fixes

* Update .clang-tidy

- ignore performance-enum-size

* Update CI workflow

- update paths-ignore

* Add linting workflow

- runs clang-tidy

* Update cmake/rocprofiler_build_settings.cmake

- minor modification of flags not recognized by clang-tidy

* Update samples (all of them)

- rocprofiler-samples-build-flags target with -W -Wall -Wextra -Wshadow [-Werror]
- Link samples targets to rocprofiler-samples-build-flags if target exists
- Remove unused variable in main.cpp of api_{buffered,callback}_tracing
- Update samples/pc_sampling
  - single-user-multiple-agents.cpp ends up with unused function find_first_gpu_agent() error
  - change find_first_gpu_agent to return std::optional<rocprofiler_agent_t>
  - change usage after call to find_first_gpu_agent()
  - use find_first_gpu_agent() in single-user-multiple-agents.cpp to determine if there are any GPUs

* Update linting workflow

- fix path to run-ci.py script

* Update linting workflow

- install cmake

* Update common/container/stable_vector.hpp

- fix clang-tidy warning for readability-container-size-empty

[ROCm/rocprofiler-sdk commit: 34505943b2]
This commit is contained in:
Jonathan R. Madsen
2023-09-21 14:35:20 -05:00
committed by GitHub
parent ac832eb2c7
commit 218666ebe9
19 changed files with 173 additions and 45 deletions
@@ -1 +1,5 @@
#
#
#
rocprofiler_activate_clang_tidy()
@@ -1,6 +1,8 @@
#
# Builds common utilities into a static library
#
rocprofiler_activate_clang_tidy()
set(common_sources config.cpp environment.cpp demangle.cpp)
set(common_headers config.hpp defines.hpp environment.hpp demangle.hpp mpl.hpp
utility.hpp)
@@ -195,7 +195,7 @@ public:
size_type max_size() const noexcept { return std::numeric_limits<size_type>::max(); }
size_type capacity() const noexcept { return m_chunks.size() * ChunkSizeV; }
bool empty() const noexcept { return m_chunks.size() == 0; }
bool empty() const noexcept { return m_chunks.empty(); }
void reserve(size_type new_capacity);
void shrink_to_fit() noexcept {}
@@ -1,6 +1,8 @@
#
#
#
rocprofiler_activate_clang_tidy()
set(ROCPROFILER_LIB_HEADERS buffer.hpp internal_threading.hpp registration.hpp)
set(ROCPROFILER_LIB_SOURCES
buffer.cpp buffer_tracing.cpp callback_tracing.cpp context.cpp internal_threading.cpp