Enable Lintian Support for ROCM-SMI, ROCMINFO (#1650)

* Enable Lintian Support for ROCM-SMI * Enable Lintian Support for ROCMINFO * Updated Lintian Override File Processing * Update UT Fix for Lintian rocmsmi,rocminfo * Update UT Fixes, Review Comments * Update Review Comments - removed extra white spaces, added error check for gzip, date commands * Update Review Comments - Correcting License Type * Sync Lintian ChangeLog * Changelog data sync enhanced * Update Review Comments, UT fix * white space cleanup - precommit check
2025-12-15 15:35:28 -05:00
parent 1240b592a5
commit 21afa807a9
10 changed files with 542 additions and 7 deletions
@@ -91,6 +91,20 @@ set(PKG_VERSION_GIT_TAG_PREFIX "rocminfo_pkg_ver")

 find_program (GIT NAMES git)

+# Set Lintian Support Flags
+set(BUILD_ENABLE_LINTIAN_OVERRIDES
+    OFF
+    CACHE BOOL
+    "Enable/Disable Lintian Overrides"
+)
+set(BUILD_DEBIAN_PKGING_FLAG
+    OFF
+    CACHE BOOL
+    "Internal Status Flag to indicate Debian Packaging Build"
+)
+# No Library for rocminfo, So no ASAN specific package, no asan comp type
+set(COMP_TYPE "dev")
+
 get_package_version_number("1.0.0" ${PKG_VERSION_GIT_TAG_PREFIX} GIT)
 # VERSION_* variables should be set by get_version_from_tag
 message("Package version: ${PKG_VERSION_STR}")
@@ -195,7 +209,9 @@ set(CPACK_PACKAGE_VENDOR "Advanced Micro Devices, Inc.")
 set(CPACK_PACKAGE_VERSION_MAJOR "${PKG_VERSION_MAJOR}")
 set(CPACK_PACKAGE_VERSION_MINOR "${PKG_VERSION_MINOR}")
 set(CPACK_PACKAGE_VERSION_PATCH "${PKG_VERSION_PATCH}")
-set(CPACK_PACKAGE_CONTACT "AMD Rocminfo Support <rocminfo.support@amd.com>")
+set(PKG_MAINTAINER_NM "AMD Rocminfo Support")
+set(PKG_MAINTAINER_EMAIL "rocminfo.support@amd.com")
+set(CPACK_PACKAGE_CONTACT "${PKG_MAINTAINER_NM} <${PKG_MAINTAINER_EMAIL}>")
 set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/License.txt")
 set( CPACK_RPM_PACKAGE_LICENSE "NCSA" )
 set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "Radeon Open Compute (ROCm) Runtime rocminfo tool")
@@ -268,4 +284,33 @@ if(NOT BUILD_SHARED_LIBS)
  string(REPLACE "hsa-rocr" "hsa-rocr-static-dev" CPACK_DEBIAN_PACKAGE_DEPENDS ${CPACK_DEBIAN_PACKAGE_DEPENDS})
  string(REPLACE "hsa-rocr" "hsa-rocr-static-devel" CPACK_RPM_PACKAGE_REQUIRES ${CPACK_RPM_PACKAGE_REQUIRES})
 endif()
+
+# Configure Lintian Specific Package Data
+configure_pkg( ${CPACK_PACKAGE_NAME} ${COMP_TYPE} ${CPACK_PACKAGE_VERSION} ${PKG_MAINTAINER_NM} ${PKG_MAINTAINER_EMAIL})
+
+# Custom installation for Debian Lintian File
+if(BUILD_ENABLE_LINTIAN_OVERRIDES AND BUILD_DEBIAN_PKGING_FLAG)
+    set(OVERRIDE_FILE
+        "${CMAKE_BINARY_DIR}/DEBIAN/${DEB_OVERRIDES_INSTALL_FILENM}"
+    )
+    set(OVERRIDE_TEMP_INSTALL_LOC
+        "/_CPack_Packages/Linux/DEB/${CPACK_PACKAGE_NAME}-${CPACK_PACKAGE_VERSION}-Linux/"
+    )
+    if(BUILD_SHARED_LIBS)
+        set(CPACK_INSTALL_COMMANDS
+            "${CMAKE_COMMAND} -E make_directory ${CMAKE_BINARY_DIR}${OVERRIDE_TEMP_INSTALL_LOC}${DEB_OVERRIDES_INSTALL_PATH}"
+            "${CMAKE_COMMAND} -E copy ${OVERRIDE_FILE} ${CMAKE_BINARY_DIR}${OVERRIDE_TEMP_INSTALL_LOC}${DEB_OVERRIDES_INSTALL_PATH}"
+        )
+    else()
+        set(OVERRIDE_FILE_STATIC "${DEB_OVERRIDES_INSTALL_FILENM}-static-dev")
+        set(OVERRIDE_FILE_STATIC_DEST
+            "${CMAKE_BINARY_DIR}${OVERRIDE_TEMP_INSTALL_LOC}${DEB_OVERRIDES_INSTALL_PATH}${OVERRIDE_FILE_STATIC}"
+        )
+        set(CPACK_INSTALL_COMMANDS
+            "${CMAKE_COMMAND} -E make_directory ${CMAKE_BINARY_DIR}${OVERRIDE_TEMP_INSTALL_LOC}${DEB_OVERRIDES_INSTALL_PATH}"
+            "${CMAKE_COMMAND} -E copy ${OVERRIDE_FILE} ${OVERRIDE_FILE_STATIC_DEST}"
+        )
+    endif()
+endif()
+
 include ( CPack )
@@ -0,0 +1,4 @@
+@DEB_PACKAGE_NAME@ (@DEB_PACKAGE_VERSION@) stable; urgency=low
+
+  * ROCm Runtime software stack Base Package.
+ -- @DEB_MAINTAINER_NAME@ <@DEB_MAINTAINER_EMAIL@>  @DEB_TIMESTAMP@
@@ -0,0 +1,7 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: @DEB_PACKAGE_NAME@
+Upstream-Contact: @DEB_MAINTAINER_NAME@ <@DEB_MAINTAINER_EMAIL@>
+Source: https://github.com/ROCm/rocm-systems
+Files: *
+License: @DEB_LICENSE@
+Copyright: @DEB_COPYRIGHT_YEAR@ Advanced Micro Devices, Inc. All rights reserved.
@@ -0,0 +1,3 @@
+@DEB_OVERRIDES_INSTALL_FILENM@: no-copyright-file
+@DEB_OVERRIDES_INSTALL_FILENM@: debian-changelog-file-missing
+@DEB_OVERRIDES_INSTALL_FILENM@: dir-or-file-in-opt
@@ -160,3 +160,190 @@ function(get_package_version_number DEFAULT_VERSION_STRING VERSION_PREFIX GIT)
    set(PKG_VERSION_STR "${PKG_VERSION_STR}-${VERSION_HASH}")
    set(PKG_VERSION_STR ${PKG_VERSION_STR} PARENT_SCOPE)
 endfunction()
+
+## Configure Lintian Specific install Files for Debian Package
+function(
+    configure_pkg
+    PACKAGE_NAME_T
+    COMPONENT_NAME_T
+    PACKAGE_VERSION_T
+    MAINTAINER_NM_T
+    MAINTAINER_EMAIL_T
+)
+    # Check If Debian Platform
+    find_file(DEBIAN debian_version debconf.conf PATHS /etc)
+    if(DEBIAN)
+        set(BUILD_ENABLE_LINTIAN_OVERRIDES
+            ON
+            CACHE BOOL
+            "Enable/Disable Lintian Overrides"
+            FORCE
+        )
+        set(BUILD_DEBIAN_PKGING_FLAG
+            ON
+            CACHE BOOL
+            "Internal Status Flag to indicate Debian Packaging Build"
+            FORCE
+        )
+        set_debian_pkg_cmake_flags(${PACKAGE_NAME_T} ${PACKAGE_VERSION_T}
+                                  ${MAINTAINER_NM_T} ${MAINTAINER_EMAIL_T}
+        )
+
+        # Create debian directory in build tree
+        file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/DEBIAN")
+
+        # Configure the copyright file
+        configure_file(
+            "${CMAKE_SOURCE_DIR}/DEBIAN/copyright.in"
+            "${CMAKE_BINARY_DIR}/DEBIAN/copyright"
+            @ONLY
+        )
+
+        # Install copyright file
+        install(
+            FILES "${CMAKE_BINARY_DIR}/DEBIAN/copyright"
+            DESTINATION "${CMAKE_INSTALL_DOCDIR}"
+            COMPONENT ${COMPONENT_NAME_T}
+        )
+
+        # Configure the changelog file
+        configure_file(
+            "${CMAKE_SOURCE_DIR}/DEBIAN/changelog.in"
+            "${CMAKE_BINARY_DIR}/DEBIAN/changelog.Debian"
+            @ONLY
+        )
+
+        # Install Change Log
+        find_program(DEB_GZIP_EXEC gzip)
+        if(NOT DEB_GZIP_EXEC)
+            message(
+                FATAL_ERROR
+                "gzip command not found: Failed to compress the changelog"
+            )
+        endif()
+        if(EXISTS "${CMAKE_BINARY_DIR}/DEBIAN/changelog.Debian")
+            execute_process(
+                COMMAND
+                    ${DEB_GZIP_EXEC} -f -n -9
+                    "${CMAKE_BINARY_DIR}/DEBIAN/changelog.Debian"
+                WORKING_DIRECTORY "${CMAKE_BINARY_DIR}/DEBIAN"
+                RESULT_VARIABLE result
+                OUTPUT_VARIABLE output
+                ERROR_VARIABLE error
+            )
+            if(NOT ${result} EQUAL 0)
+                message(FATAL_ERROR "Failed to compress: ${error}")
+            endif()
+            install(
+                FILES
+                    "${CMAKE_BINARY_DIR}/DEBIAN/${DEB_CHANGELOG_INSTALL_FILENM}"
+                DESTINATION ${CMAKE_INSTALL_DOCDIR}
+                COMPONENT ${COMPONENT_NAME_T}
+            )
+        endif()
+        if(BUILD_ENABLE_LINTIAN_OVERRIDES)
+            if(ENABLE_ASAN_PACKAGING)
+                string(FIND ${DEB_OVERRIDES_INSTALL_FILENM} "asan" OUT_VAR2)
+                if(OUT_VAR2 EQUAL -1)
+                    set(DEB_OVERRIDES_INSTALL_FILENM
+                        "${DEB_OVERRIDES_INSTALL_FILENM}-asan"
+                        CACHE STRING
+                        "Debian Package Lintian Override File Name"
+                        FORCE
+                    )
+                endif()
+            endif()
+            # Configure the Lintian overrides file
+            configure_file(
+                "${CMAKE_SOURCE_DIR}/DEBIAN/overrides.in"
+                "${CMAKE_BINARY_DIR}/DEBIAN/${DEB_OVERRIDES_INSTALL_FILENM}"
+                FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
+                @ONLY
+            )
+        endif()
+    endif()
+endfunction()
+
+# Set variables for changelog and copyright
+# For Debian specific Packages
+function(
+    set_debian_pkg_cmake_flags
+    DEB_PACKAGE_NAME_T
+    DEB_PACKAGE_VERSION_T
+    DEB_MAINTAINER_NM_T
+    DEB_MAINTAINER_EMAIL_T
+)
+    # Setting configure flags
+    set(DEB_PACKAGE_NAME
+        "${DEB_PACKAGE_NAME_T}"
+        CACHE STRING
+        "Debian Package Name"
+    )
+    set(DEB_PACKAGE_VERSION
+        "${DEB_PACKAGE_VERSION_T}"
+        CACHE STRING
+        "Debian Package Version String"
+    )
+    set(DEB_MAINTAINER_NAME
+        "${DEB_MAINTAINER_NM_T}"
+        CACHE STRING
+        "Debian Package Maintainer Name"
+    )
+    set(DEB_MAINTAINER_EMAIL
+        "${DEB_MAINTAINER_EMAIL_T}"
+        CACHE STRING
+        "Debian Package Maintainer Email"
+    )
+    set(DEB_COPYRIGHT_YEAR "2025" CACHE STRING "Debian Package Copyright Year")
+    set(DEB_LICENSE "NCSA" CACHE STRING "Debian Package License Type")
+    set(DEB_CHANGELOG_INSTALL_FILENM
+        "changelog.Debian.gz"
+        CACHE STRING
+        "Debian Package ChangeLog File Name"
+    )
+
+    if(BUILD_ENABLE_LINTIAN_OVERRIDES)
+        set(DEB_OVERRIDES_INSTALL_FILENM
+            "${DEB_PACKAGE_NAME}"
+            CACHE STRING
+            "Debian Package Lintian Override File Name"
+        )
+        set(DEB_OVERRIDES_INSTALL_PATH
+            "/usr/share/lintian/overrides/"
+            CACHE STRING
+            "Deb Pkg Lintian Override Install Loc"
+        )
+    endif()
+
+    # Get TimeStamp
+    find_program(DEB_DATE_TIMESTAMP_EXEC date)
+    if(NOT DEB_DATE_TIMESTAMP_EXEC)
+        message(
+            FATAL_ERROR
+            "date command not found: Failed to Configure the timestamp for Copyright/Changelog."
+        )
+    endif()
+    set(DEB_TIMESTAMP_FORMAT_OPTION "-R")
+    execute_process(
+        COMMAND ${DEB_DATE_TIMESTAMP_EXEC} ${DEB_TIMESTAMP_FORMAT_OPTION}
+        OUTPUT_VARIABLE TIMESTAMP_T
+        OUTPUT_STRIP_TRAILING_WHITESPACE
+    )
+    set(DEB_TIMESTAMP
+        "${TIMESTAMP_T}"
+        CACHE STRING
+        "Current Time Stamp for Copyright/Changelog"
+    )
+
+    message(STATUS "DEB_PACKAGE_NAME             : ${DEB_PACKAGE_NAME}")
+    message(STATUS "DEB_PACKAGE_VERSION          : ${DEB_PACKAGE_VERSION}")
+    message(STATUS "DEB_MAINTAINER_NAME          : ${DEB_MAINTAINER_NAME}")
+    message(STATUS "DEB_MAINTAINER_EMAIL         : ${DEB_MAINTAINER_EMAIL}")
+    message(STATUS "DEB_COPYRIGHT_YEAR           : ${DEB_COPYRIGHT_YEAR}")
+    message(STATUS "DEB_LICENSE                  : ${DEB_LICENSE}")
+    message(STATUS "DEB_TIMESTAMP                : ${DEB_TIMESTAMP}")
+    message(
+        STATUS
+        "DEB_CHANGELOG_INSTALL_FILENM : ${DEB_CHANGELOG_INSTALL_FILENM}"
+    )
+endfunction()