look for symbols in dynsym table (#990)

* look for symbols in dynsym table

* checking both symtab and dynsym

* Avoid symbol duplication in non stripped binaries

* clang-format

* Minor elf_utils.cpp updates

- use 'else if' instead of 'if'
- logging tweaks

* Update registration

- tweak logging

* Update testing

- strip the rocprofiler-sdk-c-tool library
- add test-c-tool-rocp-tool-lib-execute test which does NOT LD_PRELOAD the library (uses only ROCP_TOOL_LIBRARIES instead)

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: dc671497da]

projects/rocprofiler-sdk/tests/c-tool/CMakeLists.txt

@@ -37,3 +37,26 @@ set_tests_properties(
         "Test C tool \\(priority=0\\) is using rocprofiler-sdk v([0-9]+\\.[0-9]+\\.[0-9]+)"
         FAIL_REGULAR_EXPRESSION
         "${ROCPROFILER_DEFAULT_FAIL_REGEX}")
+
+# this test uses ROCP_TOOL_LIBRARIES instead of LD_PRELOAD
+add_test(NAME test-c-tool-rocp-tool-lib-execute COMMAND $<TARGET_FILE:transpose> 1)
+
+set(c-tool-rocp-tool-lib-env
+    "${ROCPROFILER_MEMCHECK_PRELOAD_ENV}"
+    "ROCP_TOOL_LIBRARIES=$<TARGET_FILE:rocprofiler-sdk-c-tool>"
+    "LD_LIBRARY_PATH=$<TARGET_FILE_DIR:rocprofiler-sdk::rocprofiler-shared-library>:$ENV{LD_LIBRARY_PATH}"
+    )
+
+set_tests_properties(
+    test-c-tool-rocp-tool-lib-execute
+    PROPERTIES
+        TIMEOUT
+        45
+        LABELS
+        "integration-tests"
+        ENVIRONMENT
+        "${c-tool-rocp-tool-lib-env}"
+        PASS_REGULAR_EXPRESSION
+        "Test C tool \\(priority=0\\) is using rocprofiler-sdk v([0-9]+\\.[0-9]+\\.[0-9]+)"
+        FAIL_REGULAR_EXPRESSION
+        "${ROCPROFILER_DEFAULT_FAIL_REGEX}")

projects/rocprofiler-sdk/tests/tools/CMakeLists.txt

@@ -38,3 +38,14 @@ set_target_properties(
                VERSION
                ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}
                INSTALL_RPATH "\$ORIGIN:\$ORIGIN/..")
+
+if(NOT CMAKE_STRIP)
+    find_program(CMAKE_STRIP NAMES strip REQUIRED)
+endif()
+
+add_custom_command(
+    TARGET rocprofiler-sdk-c-tool
+    POST_BUILD
+    COMMAND ${CMAKE_STRIP} $<TARGET_FILE:rocprofiler-sdk-c-tool>
+    WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
+    COMMENT "Stripping rocprofiler-sdk-c-tool...")