From 260b54adb998235d777e0698b155ef36c8d5d8e4 Mon Sep 17 00:00:00 2001 From: Wenkai Du <43822138+wenkaidu@users.noreply.github.com> Date: Thu, 18 Mar 2021 18:08:08 -0700 Subject: [PATCH] Hide non-public symbols from library (#332) * Hide non-public symbols from library * Move flag outside of parallel-jobs check [ROCm/rccl commit: 244e25d980f3cd71302a591156e5b658742bf1cd] --- projects/rccl/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/projects/rccl/CMakeLists.txt b/projects/rccl/CMakeLists.txt index 7b24d0abcf..a3511c3409 100644 --- a/projects/rccl/CMakeLists.txt +++ b/projects/rccl/CMakeLists.txt @@ -184,6 +184,7 @@ target_link_libraries(rccl PRIVATE --cuda-gpu-arch=${target}) endforeach() if("${HIP_COMPILER}" MATCHES "clang") + target_compile_options(rccl PRIVATE -fvisibility=hidden) foreach(target ${AMDGPU_TARGETS}) target_compile_options(rccl PRIVATE --cuda-gpu-arch=${target} PRIVATE -fgpu-rdc) endforeach()