AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

EXSWHTEC-24 - Fix issues and refactor code in Stream Management tests (#2916)

Browse Source 
- Fix bug in calculation of normal priority in Unit_hipStreamGetPriority_StreamsWithCUMask tests
- Delete duplicate test Unit_hipStreamGetPriority_InvalidPriorityPointer
- Separate Unit_hipStreamAddCallback_ParamTst into positive and negative test
- Remove Unit_hipStreamDestroy_Negative_DoubleDestroy test for Nvidia devices due to error

[ROCm/hip commit: d60b65b5dc]
This commit is contained in:
nives-vukovic
2022-09-26 07:33:18 +02:00
committed by GitHub
parent d45eb3bb01
commit 263e58230b
2 changed files with 40 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/hip/tests/catch/unit/stream/hipStreamAddCallback.cc
+39 -28
View File
@@ -161,16 +161,52 @@ using hipStreaAddCallbackTest::Callback_ChkStreamValue;
/*
* Validates parameter list of hipStreamAddCallback.
*/
TEST_CASE("Unit_hipStreamAddCallback_ParamTst") {
TEST_CASE("Unit_hipStreamAddCallback_ParamTst_Positive") {
hipStream_t mystream;
HIP_CHECK(hipStreamCreate(&mystream));
// Scenario1
SECTION("callback is nullptr") {
SECTION("userData pointer value validation") {
gstream = mystream;
gusrptr = ptr0xff;
gPassed = true;
gcbDone = false;
HIP_CHECK(hipStreamAddCallback(mystream, Callback_ChkUsrdataPtr,
gusrptr, 0));
while (!gcbDone) {
std::this_thread::sleep_for(std::chrono::microseconds(100000)); // Sleep for 100 ms
}
REQUIRE(gPassed);
}
// Scenario2
SECTION("stream value validation") {
gstream = mystream;
gPassed = true;
gcbDone = false;
HIP_CHECK(hipStreamAddCallback(mystream, Callback_ChkStreamValue,
nullptr, 0));
while (!gcbDone) {
std::this_thread::sleep_for(std::chrono::microseconds(100000)); // Sleep for 100 ms
}
REQUIRE(gPassed);
}
HIP_CHECK(hipStreamDestroy(mystream));
}
/*
* Negative tests for validation of hipStreamAddCallback parameter list.
*/
TEST_CASE("Unit_hipStreamAddCallback_ParamTst_Negative") {
hipStream_t mystream;
HIP_CHECK(hipStreamCreate(&mystream));
// Scenario1
SECTION("callback is nullptr for non-default stream") {
REQUIRE_FALSE(hipSuccess == hipStreamAddCallback(mystream, nullptr,
nullptr, 0));
}
// Scenario2
SECTION("stream is default") {
SECTION("callback is nullptr for default stream") {
REQUIRE_FALSE(hipSuccess == hipStreamAddCallback(0, nullptr,
nullptr, 0));
}
@@ -184,31 +220,6 @@ TEST_CASE("Unit_hipStreamAddCallback_ParamTst") {
REQUIRE_FALSE(hipSuccess == hipStreamAddCallback(0, Callback,
nullptr, 10));
}
// Scenario5
SECTION("userData pointer value validation") {
gstream = mystream;
gusrptr = ptr0xff;
gPassed = true;
gcbDone = false;
HIP_CHECK(hipStreamAddCallback(mystream, Callback_ChkUsrdataPtr,
gusrptr, 0));
while (!gcbDone) {
std::this_thread::sleep_for(std::chrono::microseconds(100000)); // Sleep for 100 ms
}
REQUIRE_FALSE(!gPassed);
}
// Scenario6
SECTION("stream value validation") {
gstream = mystream;
gPassed = true;
gcbDone = false;
HIP_CHECK(hipStreamAddCallback(mystream, Callback_ChkStreamValue,
nullptr, 0));
while (!gcbDone) {
std::this_thread::sleep_for(std::chrono::microseconds(100000)); // Sleep for 100 ms
}
REQUIRE_FALSE(!gPassed);
}
HIP_CHECK(hipStreamDestroy(mystream));
}