diff --git a/catch/hipTestMain/config/config_amd_linux b/catch/hipTestMain/config/config_amd_linux index 6d5a3d372a..cd4ef8d14f 100644 --- a/catch/hipTestMain/config/config_amd_linux +++ b/catch/hipTestMain/config/config_amd_linux @@ -219,7 +219,6 @@ "Unit_hipExtLaunchMultiKernelMultiDevice_Negative_MultiKernelSameDevice", "=== Below tests are failing PSDB ===", "Unit_hipGraphExecMemcpyNodeSetParams_Positive_Basic", - "Unit_hipGraphExecMemcpyNodeSetParams_Negative_Parameters", "Unit_hipMemcpy3D_Positive_Synchronization_Behavior", "Unit_hipMemcpyParam2D_Positive_Synchronization_Behavior", "Unit_hipMemcpyAsync_Positive_Synchronization_Behavior", diff --git a/catch/hipTestMain/config/config_amd_windows b/catch/hipTestMain/config/config_amd_windows index 035385cc79..3ef3d1acea 100644 --- a/catch/hipTestMain/config/config_amd_windows +++ b/catch/hipTestMain/config/config_amd_windows @@ -361,7 +361,6 @@ "Unit_hipFreeMipmappedArray_Negative_DoubleFree", "Unit_hipFreeMipmappedArrayMultiTArray - int", "Unit_hipGraphExecMemcpyNodeSetParams_Positive_Basic", - "Unit_hipGraphExecMemcpyNodeSetParams_Negative_Parameters", "Unit_hipMemcpy3D_Positive_Synchronization_Behavior", "Unit_hipMemcpyParam2D_Positive_Synchronization_Behavior", "Unit_hipMemcpyAsync_Positive_Synchronization_Behavior", diff --git a/catch/unit/graph/hipGraphExecMemcpyNodeSetParams.cc b/catch/unit/graph/hipGraphExecMemcpyNodeSetParams.cc index 27da2db6f5..f22dbd68ff 100644 --- a/catch/unit/graph/hipGraphExecMemcpyNodeSetParams.cc +++ b/catch/unit/graph/hipGraphExecMemcpyNodeSetParams.cc @@ -165,9 +165,10 @@ TEST_CASE("Unit_hipGraphExecMemcpyNodeSetParams_Negative_Parameters") { int src[2] = {}, dst[2] = {}; - auto params = GetMemcpy3DParms(make_hipPitchedPtr(dst, 0, sizeof(dst), 0), make_hipPos(0, 0, 0), - make_hipPitchedPtr(src, 0, sizeof(src), 0), make_hipPos(0, 0, 0), - make_hipExtent(sizeof(dst), 1, 1), hipMemcpyDefault); + auto params = + GetMemcpy3DParms(make_hipPitchedPtr(dst, sizeof(dst), sizeof(dst), 0), make_hipPos(0, 0, 0), + make_hipPitchedPtr(src, sizeof(src), sizeof(src), 0), make_hipPos(0, 0, 0), + make_hipExtent(sizeof(dst), 1, 1), hipMemcpyDefault); hipGraphNode_t node = nullptr; HIP_CHECK(hipGraphAddMemcpyNode(&node, graph, nullptr, 0, ¶ms)); @@ -185,9 +186,10 @@ TEST_CASE("Unit_hipGraphExecMemcpyNodeSetParams_Negative_Parameters") { } auto f = [&](void* dst, void* src, size_t count, hipMemcpyKind kind) { - auto params = GetMemcpy3DParms(make_hipPitchedPtr(dst, 0, sizeof(dst), 0), make_hipPos(0, 0, 0), - make_hipPitchedPtr(src, 0, sizeof(src), 0), make_hipPos(0, 0, 0), - make_hipExtent(count, 1, 1), kind); + auto params = + GetMemcpy3DParms(make_hipPitchedPtr(dst, sizeof(dst), sizeof(dst), 0), make_hipPos(0, 0, 0), + make_hipPitchedPtr(src, sizeof(src), sizeof(src), 0), make_hipPos(0, 0, 0), + make_hipExtent(count, 1, 1), kind); return hipGraphExecMemcpyNodeSetParams(graph_exec, node, ¶ms); }; MemcpyWithDirectionCommonNegativeTests(f, dst, src, sizeof(dst), hipMemcpyDefault); @@ -200,14 +202,14 @@ TEST_CASE("Unit_hipGraphExecMemcpyNodeSetParams_Negative_Parameters") { SECTION("count larger than dst allocation size") { LinearAllocGuard dev_dst(LinearAllocs::hipMalloc, sizeof(int)); - params.dstPtr = make_hipPitchedPtr(dev_dst.ptr(), 0, sizeof(int), 0); + params.dstPtr = make_hipPitchedPtr(dev_dst.ptr(), sizeof(int), sizeof(int), 0); HIP_CHECK_ERROR(hipGraphExecMemcpyNodeSetParams(graph_exec, node, ¶ms), hipErrorInvalidValue); } SECTION("count larger than src allocation size") { LinearAllocGuard dev_src(LinearAllocs::hipMalloc, sizeof(int)); - params.dstPtr = make_hipPitchedPtr(dev_src.ptr(), 0, sizeof(int), 0); + params.dstPtr = make_hipPitchedPtr(dev_src.ptr(), sizeof(int), sizeof(int), 0); HIP_CHECK_ERROR(hipGraphExecMemcpyNodeSetParams(graph_exec, node, ¶ms), hipErrorInvalidValue); }