From 2840ac013948010e87e78771fab8826b973cb8f1 Mon Sep 17 00:00:00 2001 From: Rashika Kheria Date: Wed, 18 Jan 2023 04:53:12 +0000 Subject: [PATCH] Fix maximum handle size for NCCL Net v4 API NCCL Net v4 supports a maximum handle size of 64 bytes whereas the ext-net example header files set it for NCCL Net v3. Since, `aws-ofi-nccl` plugin plans to follow the example header files, fix it here. Signed-off-by: Rashika Kheria [ROCm/rccl commit: 93840e7476207bb8a2ba18820ef1e906fb5eea62] --- projects/rccl/ext-net/example/nccl/net_v3.h | 1 - projects/rccl/ext-net/example/nccl/net_v4.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/projects/rccl/ext-net/example/nccl/net_v3.h b/projects/rccl/ext-net/example/nccl/net_v3.h index 26d117c9ba..db1287b473 100644 --- a/projects/rccl/ext-net/example/nccl/net_v3.h +++ b/projects/rccl/ext-net/example/nccl/net_v3.h @@ -5,7 +5,6 @@ #ifndef NCCL_NET_V3_H_ #define NCCL_NET_V3_H_ -#define NCCL_NET_HANDLE_MAXSIZE_V3 64 #define NCCL_NET_MAX_REQUESTS_V3 16 typedef ncclNetProperties_v4_t ncclNetProperties_v3_t; diff --git a/projects/rccl/ext-net/example/nccl/net_v4.h b/projects/rccl/ext-net/example/nccl/net_v4.h index b39da14b18..efe4824103 100644 --- a/projects/rccl/ext-net/example/nccl/net_v4.h +++ b/projects/rccl/ext-net/example/nccl/net_v4.h @@ -5,6 +5,8 @@ #ifndef NCCL_NET_V4_H_ #define NCCL_NET_V4_H_ +#define NCCL_NET_HANDLE_MAXSIZE_V4 64 + typedef struct { char* name; // Used mostly for logging. char* pciPath; // Path to the PCI device in /sys.