From 28a7f536f9db043aa685cca1954b5258aec840f2 Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Thu, 19 Jun 2025 17:19:25 -0500 Subject: [PATCH] Fix subsystem_id str comparision Signed-off-by: Maisam Arif Change-Id: Icbe2440884458b63b42cb653009e7df36eb31e0f --- py-interface/amdsmi_interface.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/py-interface/amdsmi_interface.py b/py-interface/amdsmi_interface.py index 1fa7384e68..8fc49f0e94 100644 --- a/py-interface/amdsmi_interface.py +++ b/py-interface/amdsmi_interface.py @@ -696,7 +696,7 @@ def _pad_hex_value(value, length): return value -def _validate_if_max_uint(value, uint_type: MaxUIntegerTypes, isActivity=False, isBool=False): +def _validate_if_max_uint(value, uint_type: MaxUIntegerTypes, isActivity=False, isBool=False) -> Union[str, bool, int]: return_val = "N/A" if not isinstance(value, list): if (value == uint_type) or (isActivity and value > 100): @@ -1893,9 +1893,9 @@ def amdsmi_get_gpu_asic_info( target_graphics_version = hex(asic_info_struct.target_graphics_version)[2:] subsystem_id = _validate_if_max_uint(asic_info_struct.subsystem_id, MaxUIntegerTypes.UINT32_T) subvendor_id = _validate_if_max_uint(asic_info_struct.subvendor_id, MaxUIntegerTypes.UINT32_T) - if subsystem_id is not "N/A": + if not isinstance(subsystem_id, str): subsystem_id = _pad_hex_value(hex(subsystem_id), 4) - if subvendor_id is not "N/A": + if not isinstance(subvendor_id, str): subvendor_id = _pad_hex_value(hex(subvendor_id), 4) asic_info = { "market_name": market_name,