From 28c80c9b4e18f672c50e58f7b5af5d246bbb73ea Mon Sep 17 00:00:00 2001 From: Luna Date: Tue, 7 Jan 2025 16:49:24 -0800 Subject: [PATCH] net_ib: fix out of bounds read in ncclIbGdrSupport on non-RDMA kernel (#1470) Fixes #1469 [ROCm/rccl commit: b24580e3d4442c420aaad506d9a0996aec2e7b72] --- projects/rccl/src/transport/net_ib.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/projects/rccl/src/transport/net_ib.cc b/projects/rccl/src/transport/net_ib.cc index 6d77784422..d3863da7a1 100644 --- a/projects/rccl/src/transport/net_ib.cc +++ b/projects/rccl/src/transport/net_ib.cc @@ -586,7 +586,8 @@ ncclResult_t ncclIbGdrSupport() { // or created under a different path like `/sys/kernel/` or `/sys/` (depending on your ib_peer_mem module) const char* memory_peers_paths[] = {"/sys/kernel/mm/memory_peers/amdkfd/version", "/sys/kernel/memory_peers/amdkfd/version", - "/sys/memory_peers/amdkfd/version"}; + "/sys/memory_peers/amdkfd/version", + NULL}; int i = 0; while (memory_peers_paths[i]) {