From 2a2852048f6f4a45c9810706ce515210ce7ce3be Mon Sep 17 00:00:00 2001 From: Laurent Morichetti Date: Tue, 19 Apr 2022 14:09:20 -0700 Subject: [PATCH] Address review comments from previous commit Change-Id: I6629dd911de0d7fd08d7a863c172ec73f35fa3d1 [ROCm/roctracer commit: dc22139977e11870cca6f73a580e79790d6f837c] --- projects/roctracer/src/core/roctracer.cpp | 1 - projects/roctracer/src/proxy/simple_proxy_queue.h | 2 +- projects/roctracer/src/util/logger.h | 6 +++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/projects/roctracer/src/core/roctracer.cpp b/projects/roctracer/src/core/roctracer.cpp index 4464b1404e..70b6679603 100644 --- a/projects/roctracer/src/core/roctracer.cpp +++ b/projects/roctracer/src/core/roctracer.cpp @@ -763,7 +763,6 @@ static inline uint32_t get_op_end(uint32_t domain) { return HIP_OP_ID_NUMBER; case ACTIVITY_DOMAIN_HIP_API: return HIP_API_ID_LAST + 1; - ; case ACTIVITY_DOMAIN_EXT_API: return 0; case ACTIVITY_DOMAIN_ROCTX: diff --git a/projects/roctracer/src/proxy/simple_proxy_queue.h b/projects/roctracer/src/proxy/simple_proxy_queue.h index 3b76c4bf30..4c588b22db 100644 --- a/projects/roctracer/src/proxy/simple_proxy_queue.h +++ b/projects/roctracer/src/proxy/simple_proxy_queue.h @@ -124,7 +124,7 @@ class SimpleProxyQueue : public ProxyQueue { // Compute the write index of queue const uint64_t que_idx = hsa_queue_load_write_index_relaxed_fn(queue_); - // Waiting untill there is a free space in the queue + // Waiting until there is a free space in the queue while (que_idx >= (hsa_queue_load_read_index_relaxed_fn(queue_) + size_)) ; diff --git a/projects/roctracer/src/util/logger.h b/projects/roctracer/src/util/logger.h index e4927df2f0..ed3709af88 100644 --- a/projects/roctracer/src/util/logger.h +++ b/projects/roctracer/src/util/logger.h @@ -190,9 +190,9 @@ class Logger { #define DBG_LOGGING(stream) \ do { \ roctracer::util::Logger::Instance() \ - << roctracer::util::Logger::begm << "debug: \"" << stream << "\"" < < < < \ - " in " << __FUNCTION__ << " at " << __FILE__ << " line " << __LINE__ \ - << roctracer::util::Logger::endl; \ + << roctracer::util::Logger::begm << "debug: \"" << stream << "\"" \ + << " in " << __FUNCTION__ << " at " << __FILE__ << " line " << __LINE__ \ + << roctracer::util::Logger::endl; \ } while (0) #endif