From 2c367bc8afefe5cf195aac8437d5d0e43841d3e2 Mon Sep 17 00:00:00 2001 From: Evgeny Mankov Date: Thu, 25 Oct 2018 17:09:18 +0300 Subject: [PATCH] [HIPIFY][cmake][fix] Mark all target_link_libraries with PRIVATE keyword [Reason] Avoid cmake error occurred when mixing signatures with AddLLVM.cmake [Error] CMake Error at CMakeLists.txt:26 (target_link_libraries): The keyword signature for target_link_libraries has already been used with the target "hipify-clang". All uses of target_link_libraries with a target must be either all-keyword or all-plain. Error occurred only on Linux and LLVM 7.0.0 --- hipify-clang/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hipify-clang/CMakeLists.txt b/hipify-clang/CMakeLists.txt index a3952ba418..56de7c7904 100644 --- a/hipify-clang/CMakeLists.txt +++ b/hipify-clang/CMakeLists.txt @@ -23,7 +23,7 @@ set(CMAKE_CXX_COMPILER ${LLVM_TOOLS_BINARY_DIR}/clang++) set(CMAKE_C_COMPILER ${LLVM_TOOLS_BINARY_DIR}/clang) # Link against LLVM and CLANG libraries -target_link_libraries(hipify-clang +target_link_libraries(hipify-clang PRIVATE clangASTMatchers clangFrontend clangTooling @@ -48,11 +48,11 @@ target_link_libraries(hipify-clang LLVMCore) if(WIN32) - target_link_libraries(hipify-clang version) + target_link_libraries(hipify-clang PRIVATE version) endif() if ((LLVM_PACKAGE_VERSION VERSION_EQUAL "7") OR (LLVM_PACKAGE_VERSION VERSION_GREATER "7")) - target_link_libraries(hipify-clang clangToolingInclusions) + target_link_libraries(hipify-clang PRIVATE clangToolingInclusions) endif() set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS}")