AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-563777 - fix warnings related to inconsistent overrides (#1625)

Browse Source 
This patch adds missing override keywords. Fixes this class of warnings.

Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com>
This commit is contained in:
sluzynsk-amd
2025-11-24 12:50:07 -05:00
committed by GitHub
parent 1a3564a51a
commit 2cf9faa93f
6 changed files with 52 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/rocclr/platform/command.hpp
+3 -3
View File
@@ -502,7 +502,7 @@ class OneMemoryArgCommand : public Command {
memory_->retain();
}
virtual void releaseResources() {
virtual void releaseResources() override {
memory_->release();
DEBUG_ONLY(memory_ = NULL);
Command::releaseResources();
@@ -510,14 +510,14 @@ class OneMemoryArgCommand : public Command {
}
//! Release all pinned memory for this command
virtual void ReleasePinnedMemory() {
virtual void ReleasePinnedMemory() override {
for (auto it : pinned_memory_) {
it->release();
}
pinned_memory_.clear();
}
//! Release all pinned memory for this command
virtual bool IsMemoryPinned() const { return !pinned_memory_.empty(); }
virtual bool IsMemoryPinned() const override { return !pinned_memory_.empty(); }
//! Adds pinned memory, used in this command for later release
virtual void AddPinnedMemory(Memory* pinned) override { pinned_memory_.push_back(pinned); }