AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-485904 - propagate hsa_amd_vmem_address_free error to hip API

Browse Source 
Unit_hipMemSetAccess_GrowVMM test fails with
HSA_STATUS_ERROR_RESOURCE_FREE silently

Change-Id: I7a78410e432de4a2e877062782abf8761645f392


[ROCm/clr commit: b498103f9b]
This commit is contained in:
Anusha GodavarthySurya
2024-09-20 12:08:42 +00:00
committed by Anusha Godavarthy Surya
parent d65afe707c
commit 2dccb30f6f
6 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/hipamd/src/hip_vm.cpp
+5 -3
View File
@@ -35,7 +35,7 @@ static_assert(static_cast<uint32_t>(hipMemAccessFlagsProtReadWrite)
hipError_t hipMemAddressFree(void* devPtr, size_t size) {
HIP_INIT_API(hipMemAddressFree, devPtr, size);
hipError_t status = hipSuccess;
if (devPtr == nullptr || size == 0) {
HIP_RETURN(hipErrorInvalidValue);
}
@@ -44,9 +44,11 @@ hipError_t hipMemAddressFree(void* devPtr, size_t size) {
LogPrintfError("Cannot find the Virtual MemObj entry for this addr 0x%x", devPtr);
}
// Single call frees address range for all devices.
g_devices[0]->devices()[0]->virtualFree(devPtr);
if (!(g_devices[0]->devices()[0]->virtualFree(devPtr))) {
status = hipErrorUnknown;
}
memObj->release();
HIP_RETURN(hipSuccess);
HIP_RETURN(status);
}
hipError_t hipMemAddressReserve(void** ptr, size_t size, size_t alignment, void* addr,