diff --git a/projects/hip-tests/catch/unit/vulkan_interop/CMakeLists.txt b/projects/hip-tests/catch/unit/vulkan_interop/CMakeLists.txt index 2f015d726a..a70940cf5c 100644 --- a/projects/hip-tests/catch/unit/vulkan_interop/CMakeLists.txt +++ b/projects/hip-tests/catch/unit/vulkan_interop/CMakeLists.txt @@ -1,6 +1,8 @@ set(TEST_SRC vulkan_test.cc hipExternalMemoryGetMappedBuffer.cc + hipImportExternalMemory.cc + hipDestroyExternalMemory.cc ) find_package(Vulkan) diff --git a/projects/hip-tests/catch/unit/vulkan_interop/hipDestroyExternalMemory.cc b/projects/hip-tests/catch/unit/vulkan_interop/hipDestroyExternalMemory.cc new file mode 100644 index 0000000000..3f7c3cc13d --- /dev/null +++ b/projects/hip-tests/catch/unit/vulkan_interop/hipDestroyExternalMemory.cc @@ -0,0 +1,45 @@ +/* +Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved. +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in +all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +THE SOFTWARE. +*/ + +#include "vulkan_test.hh" + +constexpr bool enable_validation = false; + +TEST_CASE("Unit_hipDestroyExternalMemory_Vulkan_Negative_Parameters") { + SECTION("extMem == nullptr") { + HIP_CHECK_ERROR(hipDestroyExternalMemory(nullptr), hipErrorInvalidValue); + } + +// Segfaults in CUDA +// Disabled on AMD due to defect - EXSWHTEC-187 +#if HT_AMD && 0 + SECTION("Double free") { + VulkanTest vkt(enable_validation); + const auto storage = vkt.CreateMappedStorage(1, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true); + auto desc = vkt.BuildMemoryDescriptor(storage.memory, sizeof(*storage.host_ptr)); + hipExternalMemory_t ext_memory; + HIP_CHECK(hipImportExternalMemory(&ext_memory, &desc)); + + HIP_CHECK(hipDestroyExternalMemory(ext_memory)); + HIP_CHECK_ERROR(hipDestroyExternalMemory(ext_memory), hipErrorInvalidValue); + } +#endif +} \ No newline at end of file diff --git a/projects/hip-tests/catch/unit/vulkan_interop/hipImportExternalMemory.cc b/projects/hip-tests/catch/unit/vulkan_interop/hipImportExternalMemory.cc new file mode 100644 index 0000000000..5abfada9d5 --- /dev/null +++ b/projects/hip-tests/catch/unit/vulkan_interop/hipImportExternalMemory.cc @@ -0,0 +1,76 @@ +/* +Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved. +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in +all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +THE SOFTWARE. +*/ + +#include "vulkan_test.hh" + +constexpr bool enable_validation = false; + +TEST_CASE("Unit_hipImportExternalMemory_Vulkan_Negative_Parameters") { + VulkanTest vkt(enable_validation); + const auto storage = vkt.CreateMappedStorage(1, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true); + auto desc = vkt.BuildMemoryDescriptor(storage.memory, sizeof(*storage.host_ptr)); + hipExternalMemory_t ext_memory; + +// Disabled due to defect - EXSWHTEC-182 +#if HT_NVIDIA + SECTION("extMem_out == nullptr") { + HIP_CHECK_ERROR(hipImportExternalMemory(nullptr, &desc), hipErrorInvalidValue); + } +#endif + +// Disabled due to defect - EXSWHTEC-183 +#if HT_NVIDIA + SECTION("memHandleDesc == nullptr") { + HIP_CHECK_ERROR(hipImportExternalMemory(&ext_memory, nullptr), hipErrorInvalidValue); + } +#endif + +// Disabled due to defect - EXSWHTEC-185 +#if HT_NVIDIA + SECTION("memHandleDesc.size == 0") { + desc.size = 0; + HIP_CHECK_ERROR(hipImportExternalMemory(&ext_memory, &desc), hipErrorInvalidValue); + } +#endif + +// Disabled due to defect - EXSWHTEC-186 +#if HT_NVIDIA + SECTION("Invalid memHandleDesc.flags") { + desc.flags = 2; + HIP_CHECK_ERROR(hipImportExternalMemory(&ext_memory, &desc), hipErrorInvalidValue); + } +#endif + +// Disabled due to defect - EXSWHTEC-184 +#if HT_NVIDIA + SECTION("Invalid memHandleDesc.type") { + desc.type = static_cast(-1); + HIP_CHECK_ERROR(hipImportExternalMemory(&ext_memory, &desc), hipErrorInvalidValue); + } +#endif + +#ifdef _WIN32 + SECTION("memHandleDesc.handle == NULL") { + desc.handle.win32.handle = NULL; + HIP_CHECK_ERROR(hipImportExternalMemory(&ext_memory, &desc), hipErrorInvalidValue); + } +#endif +} \ No newline at end of file