From 3243f06eef5cb3e2f3851c45b4ec5cd922837a5f Mon Sep 17 00:00:00 2001
From: Laurent Morichetti <laurent.morichetti@amd.com>
Date: Tue, 29 Oct 2019 17:46:10 -0700
Subject: [PATCH] Addressed review comments

Change comment "must exceed" to "must be no shorter than"
move the std::string instead of creating a copy
---
 hipamd/src/program_state.inl | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/hipamd/src/program_state.inl b/hipamd/src/program_state.inl
index 3dc0a9e128..993418de96 100644
--- a/hipamd/src/program_state.inl
+++ b/hipamd/src/program_state.inl
@@ -200,7 +200,7 @@ public:
                         std::function<void(hsa_code_object_reader_t*)>>;
     std::pair<
         std::mutex,
-        std::vector<std::pair<std::unique_ptr<char[]>, RAII_code_reader>>> code_readers;
+        std::vector<std::pair<std::string, RAII_code_reader>>> code_readers;
 
     program_state_impl() {
         // Create placeholder for each agent for the per-agent members.
@@ -390,22 +390,21 @@ public:
         };
 
         RAII_code_reader tmp{new hsa_code_object_reader_t, cor_deleter};
-        // The lifetime of the buffer must exceed that of the associated
-        // code object reader. Create a copy of the file, which will be
-        // released at the same time the code object reader is destroyed.
-        std::unique_ptr<char[]> buffer(new char[file.size()]);
-        memcpy(buffer.get(), file.data(), file.size());
+
+        decltype(code_readers.second)::iterator it;
+        {
+          std::lock_guard<std::mutex> lck{code_readers.first};
+          it = code_readers.second.emplace(code_readers.second.end(),
+                                           move(file), move(tmp));
+        }
 
         hsa_code_object_reader_create_from_memory(
-            buffer.get(), file.size(), tmp.get());
+            it->first.data(), it->first.size(), it->second.get());
 
         hsa_executable_load_agent_code_object(
-            executable, agent, *tmp, nullptr, nullptr);
+            executable, agent, *it->second, nullptr, nullptr);
 
         hsa_executable_freeze(executable, nullptr);
-
-        std::lock_guard<std::mutex> lck{code_readers.first};
-        code_readers.second.emplace_back(move(buffer), move(tmp));
     }
 
 
@@ -481,7 +480,7 @@ public:
                                                            code_object_dynsym,
                                                            agent, executable);
 
-        load_code_object_and_freeze_executable(ts, agent, executable);
+        load_code_object_and_freeze_executable(move(ts), agent, executable);
 
         return executable;
     }